Destination bigquery: Implement refreshes logic #38713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 28, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/core_interface_change
branch
from
a99921b to
1b8885a
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
ee71a58 to
9b7b756
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
1b8885a to
0a559fa
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
2 times, most recently
from
a8e4fb3 to
af13ed8
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
0a559fa to
84952f4
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
3 times, most recently
from
c07d187 to
7187741
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
84952f4 to
9e777b6
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
7187741 to
51ced08
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
9e777b6 to
0c713f4
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
51ced08 to
71966ff
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
0c713f4 to
2f82eef
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
71966ff to
656afed
Compare
octavia-squidington-iii
added
the
area/documentation
edgao
force-pushed
the
edgao/core_interface_change
branch
from
2f82eef to
23ca526
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
656afed to
d8eab42
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
23ca526 to
d7fd028
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
d8eab42 to
871ba24
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
d7fd028 to
4653aff
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
27824ee to
073c90b
Compare
gisripa
force-pushed
the
edgao/core_interface_change
branch
from
66838d0 to
3e6f038
Compare
gisripa
reviewed
Jun 14, 2024
| if (suffix == "") { | ||
| throw IllegalArgumentException("Cannot overwrite raw table with empty suffix") | ||
| } | ||
| bigquery.delete(tableId(streamId, "")) |
There was a problem hiding this comment.
does it have to be a no-op when table doesn't exist semantics ? if i remove IF EXISTS in snowflake, truncateRefresh tests fail. as-in this is called when actual table doesn't exist too ?
There was a problem hiding this comment.
ah, yeah there's no if rawTableExists check anywhere. We could add that, but I think it's easier to just do if not exists?
(I'll update the javadoc to clarify that that's a requirement)
edgao
force-pushed
the
edgao/core_interface_change
branch
from
3e6f038 to
d603b35
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
073c90b to
75282b3
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
d603b35 to
9178356
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
75282b3 to
388bd89
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
9178356 to
19237b7
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
388bd89 to
1c513d2
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
1c513d2 to
78ce5ef
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
78ce5ef to
c446d57
Compare
stephane-airbyte
force-pushed
the
edgao/core_interface_change
branch
from
19237b7 to
c7720b1
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
from
c7720b1 to
19024dd
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
c446d57 to
8ee43e3
Compare
edgao
force-pushed
the
edgao/core_interface_change
branch
2 times, most recently
from
dac51cc to
c14b2a8
Compare
edgao
force-pushed
the
edgao/bigquery_refreshes
branch
from
8ee43e3 to
bfb472d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?