Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-mysql]: support Planetscale MySQL's per-query row limit #40561

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

theyueli
Copy link
Contributor

Fixes https://github.com/airbytehq/oncall/issues/5051

Planet MySQL has defined multiple system limits. One of our customers has been hitting the 100K per-query row limit, making our connector emit system errors. This patch defines a chunk size limit for our connector, by default it is the largest long, and if we find it is a Planetscale MySQL, we will adjust to 100K.

@theyueli theyueli self-assigned this Jun 26, 2024
@theyueli theyueli requested a review from a team as a code owner June 26, 2024 19:01
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 0:10am

@theyueli theyueli changed the title [source-mysql]: support per-query row limit [source-mysql]: support Planetscale MySQL's per-query row limit Jun 26, 2024
Copy link
Contributor

@akashkulk akashkulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've made the change to Mssql?

@theyueli
Copy link
Contributor Author

I think you've made the change to Mssql?

oops, my mistake... these two files are almost identical.. and I got confused by their names... fixed now. Thanks!

@theyueli theyueli merged commit 42124f6 into master Jun 27, 2024
30 checks passed
@theyueli theyueli deleted the yue/planetscale branch June 27, 2024 00:29
xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
Fixes airbytehq/oncall#5051

Planet MySQL has defined multiple system limits. One of our customers has been hitting the 100K per-query row limit, which causes our connector to emit system errors. This patch defines a chunk size limit for our connector. By default, it is the largest long, and if we find it is a Planetscale MySQL, we will adjust to 100K.
@lincolnremi
Copy link

@theyueli @akashkulk @evantahler: It doesn't look like this fix made it into the V2 version of the connector that @rodireich @xiaohansong and @clnoll merged in #48369

We at Remi are also running into the 100k per-query row limit when using Airbyte's MySQL connector to replicate PlanetScale to BigQuery (the PlanetScale connector is not working for us either).

Can you point us in the direction of what a fix for this would look like? We're highly motivated to fix this and happy to submit a PR if your team is open to it.

@lincolnremi
Copy link

I don't know if this is the correct approach but I took stab at fixing this in #51055.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mssql connectors/source/mysql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants