-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge mysql v2 into v1 #48369
merge mysql v2 into v1 #48369
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@clnoll I would like to try to merge this to master to test progressive rollout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clnoll I wanted to make sure that once merged to master, this won't upgrade all existing cloud connections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodireich that's right. The -rc
suffix + enableProgressiveRollout: true
will prevent it from upgrading any connections until some are pinned.
@@ -23,7 +23,7 @@ jobs: | |||
name: Connectors Version Increment Check | |||
runs-on: connector-test-large | |||
if: github.event.pull_request.head.repo.fork != true | |||
timeout-minutes: 12 | |||
timeout-minutes: 22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was timing out
3.0.0: | ||
message: Add default cursor for cdc | ||
upgradeDeadline: "2023-08-17" | ||
releaseStage: alpha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clnoll Should this return to alpha? I wasn't sure as source-mysql was already generally_available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the releaseStage
refers to - it's not related to progressive rollouts. Maybe @alafanechere knows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is my favorite genre! /cc @nataliekwong and @alex-gron. TLDR I think is just keep it what it was :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it only affects internal reporting, not actual product behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure actually what this affects, sorry I can't be of more help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progressive rollout updates in metadata.yaml look good to me!
/giphy HUGE |
What
Progressive rollout to source-mysql V2