Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge mysql v2 into v1 #48369

Merged
merged 14 commits into from
Nov 7, 2024
Merged

merge mysql v2 into v1 #48369

merged 14 commits into from
Nov 7, 2024

Conversation

rodireich
Copy link
Contributor

@rodireich rodireich commented Nov 5, 2024

What

Progressive rollout to source-mysql V2

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:25am

@rodireich rodireich requested a review from clnoll November 6, 2024 20:39
@rodireich
Copy link
Contributor Author

rodireich commented Nov 6, 2024

@clnoll I would like to try to merge this to master to test progressive rollout.
I merged the code of source-mysql-v2 into source-mysql, so this is effectively a non breaking version of source-mysql.
It doesn't like something about the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clnoll I wanted to make sure that once merged to master, this won't upgrade all existing cloud connections.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodireich that's right. The -rc suffix + enableProgressiveRollout: true will prevent it from upgrading any connections until some are pinned.

@@ -23,7 +23,7 @@ jobs:
name: Connectors Version Increment Check
runs-on: connector-test-large
if: github.event.pull_request.head.repo.fork != true
timeout-minutes: 12
timeout-minutes: 22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was timing out

@rodireich rodireich marked this pull request as ready for review November 7, 2024 00:29
@rodireich rodireich requested review from a team as code owners November 7, 2024 00:29
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 7, 2024 00:30
3.0.0:
message: Add default cursor for cdc
upgradeDeadline: "2023-08-17"
releaseStage: alpha
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clnoll Should this return to alpha? I wasn't sure as source-mysql was already generally_available

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the releaseStage refers to - it's not related to progressive rollouts. Maybe @alafanechere knows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is my favorite genre! /cc @nataliekwong and @alex-gron. TLDR I think is just keep it what it was :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it only affects internal reporting, not actual product behavior

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure actually what this affects, sorry I can't be of more help!

Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The progressive rollout updates in metadata.yaml look good to me!

@rodireich rodireich merged commit e42d056 into master Nov 7, 2024
46 of 47 checks passed
@rodireich rodireich deleted the rodi/progressive-test-2 branch November 7, 2024 18:39
@natikgadzhi
Copy link
Contributor

/giphy HUGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mysql connectors/source/mysql-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants