[Source-Postgres] : Implement WASS algorithm #41649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…airbyte/integrations/source/mysql/initialsync/MySqlInitialLoadRecordIterator.java Co-authored-by: Evan Tahler <evan@airbyte.io>
xiaohansong
reviewed
Jul 15, 2024
airbyte-integrations/connectors/source-postgres/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
xiaohansong
reviewed
Jul 15, 2024
| final var propertiesManager = new RelationalDbDebeziumPropertiesManager( | ||
| PostgresCdcProperties.getDebeziumDefaultProperties(database), sourceConfig, catalog, cdcStreamList); | ||
| final var eventConverter = new RelationalDbDebeziumEventConverter(new PostgresCdcConnectorMetadataInjector(), emittedAt); | ||
| // Debezium is started for streams that have been started - that is they have been partially or |
There was a problem hiding this comment.
nit and optional: can you also note this is for incremental streams? (better yet I think you can put following logic into a separate function so it's pure wass operation (incremental streams only) so it doesn't confuse readers with full refresh)
There was a problem hiding this comment.
I've added the comment. However, we need to figure out the started cdc stream list here so that we can figure out in line 288 which of the scenarios the sync falls under :
- First sync (no prev state) : in which case we do initial sync + CDC
- Purely incremental sync
- WASS case
xiaohansong
reviewed
Jul 15, 2024
...gres/src/main/java/io/airbyte/integrations/source/postgres/ctid/InitialSyncCtidIterator.java
Show resolved
Hide resolved
xiaohansong
reviewed
Jul 15, 2024
...gres/src/main/java/io/airbyte/integrations/source/postgres/ctid/InitialSyncCtidIterator.java
Outdated
Show resolved
Hide resolved
xiaohansong
approved these changes
Jul 15, 2024
theyueli
reviewed
Jul 16, 2024
...es/src/main/java/io/airbyte/integrations/source/postgres/cdc/PostgresCdcCtidInitializer.java
Outdated
Show resolved
Hide resolved
theyueli
reviewed
Jul 16, 2024
...gres/src/main/java/io/airbyte/integrations/source/postgres/ctid/InitialSyncCtidIterator.java
Show resolved
Hide resolved
theyueli
approved these changes
Jul 16, 2024
...gres/src/main/java/io/airbyte/integrations/source/postgres/ctid/InitialSyncCtidIterator.java
Show resolved
Hide resolved
...in/java/io/airbyte/integrations/source/mysql/initialsync/MySqlInitialLoadRecordIterator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #38240 for Postgres