-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Source-mysql] : Implement WASS algo #38240
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...in/java/io/airbyte/integrations/source/mysql/initialsync/MySqlInitialLoadRecordIterator.java
Show resolved
Hide resolved
...sql/src/main/java/io/airbyte/integrations/source/mysql/initialsync/MySqlInitialReadUtil.java
Show resolved
Hide resolved
...sql/src/main/java/io/airbyte/integrations/source/mysql/initialsync/MySqlInitialReadUtil.java
Show resolved
Hide resolved
...sql/src/main/java/io/airbyte/integrations/source/mysql/initialsync/MySqlInitialReadUtil.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/io/airbyte/integrations/source/mysql/initialsync/MySqlInitialReadUtil.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mysql/src/test/resources/expected_cloud_spec.json
Show resolved
Hide resolved
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/publish-java-cdk
|
Co-authored-by: Evan Tahler <evan@airbyte.io>
Fixes airbytehq/airbyte-internal-issues#8730 Port of #38240 for MongoDB
Main changes here include :
MySqlInitialReadUtil
from line 272, where are 3 cases : (i) First sync (no streams in flight for initial load) (ii) Fully incremental sync (all streams finished with initial load) and (iii) WASS sync (initial load not complete)MySqlInitialLoadRecordIterator
to throw a transient error after timeout which can be configured in the specTests
Most of the changes in the unit tests are to support the second sync (aka the WASS sync, where we read off the WAL and then transition to the initial snapshot). This can happen when
In these cases, the previous state messages were in this order as initial snapshots always ran before cdc loads
STATE_PK_LOAD_1, STATE_PK_LOAD2……, STATE_PK_LOAD_FINAL, STATE_CDC_LOAD
In the same WASS case, the state messages are :
STATE_CDC_LOAD, STATE_PK_LOAD_1, STATE_PK_LOAD2……, STATE_PK_LOAD_FINAL