Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Source-mysql] : Implement WASS algo #38240

Merged
merged 40 commits into from
Jul 11, 2024
Merged

[Source-mysql] : Implement WASS algo #38240

merged 40 commits into from
Jul 11, 2024

Conversation

akashkulk
Copy link
Contributor

@akashkulk akashkulk commented May 15, 2024

Main changes here include :

  1. CDK changes : Support for Initial load timeout utils, change in global state manager to support an edge case where the cdc state manager isn't propogating per-stream state from the initial load. This would result in data loss in the "second/WASS sync" case where the state emitted in the DBZ code path would incorrectly mark in progress streams as complete.
  2. Main change in order of iterator execution is in MySqlInitialReadUtil from line 272, where are 3 cases : (i) First sync (no streams in flight for initial load) (ii) Fully incremental sync (all streams finished with initial load) and (iii) WASS sync (initial load not complete)
  3. Timeout logic in MySqlInitialLoadRecordIterator to throw a transient error after timeout which can be configured in the spec

Tests
Most of the changes in the unit tests are to support the second sync (aka the WASS sync, where we read off the WAL and then transition to the initial snapshot). This can happen when

  1. A new stream is added for the second sync. In this case, the WAL runs first and
  2. A stream is partially completed - so the WAL runs first followed by initial sync

In these cases, the previous state messages were in this order as initial snapshots always ran before cdc loads
STATE_PK_LOAD_1, STATE_PK_LOAD2……, STATE_PK_LOAD_FINAL, STATE_CDC_LOAD

In the same WASS case, the state messages are :
STATE_CDC_LOAD, STATE_PK_LOAD_1, STATE_PK_LOAD2……, STATE_PK_LOAD_FINAL

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 3:42pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jun 3, 2024
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jun 3, 2024
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jun 4, 2024
@akashkulk akashkulk changed the title [DB sources] : WASS algorithm [DB sources] : POc WASS algorithm Jun 5, 2024
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jun 17, 2024
Copy link

coderabbitai bot commented Jul 10, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit-ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@theyueli theyueli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@akashkulk
Copy link
Contributor Author

akashkulk commented Jul 10, 2024

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9883104723
✅ Successfully published Java CDK version=0.41.0!

@akashkulk akashkulk enabled auto-merge (squash) July 11, 2024 15:38
@akashkulk akashkulk merged commit 310e6bd into master Jul 11, 2024
35 checks passed
@akashkulk akashkulk deleted the akash/wass-algo branch July 11, 2024 15:54
xiaohansong pushed a commit that referenced this pull request Jul 12, 2024
Co-authored-by: Evan Tahler <evan@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/mysql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants