[source-mongodb-v2] : Implement WASS algorithm #42561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
akashkulk
reviewed
Jul 26, 2024
| "default": 8, | ||
| "min": 4, | ||
| "max": 24, | ||
| "order": 10, |
There was a problem hiding this comment.
I think order should be 12 here?
There was a problem hiding this comment.
fixed, now changed to 13, and append to the end...I think I now why... I didn't want to use the 13 number initially..
akashkulk
reviewed
Jul 26, 2024
| @@ -8,7 +8,7 @@ data: | |||
| connectorSubtype: database | |||
| connectorType: source | |||
| definitionId: b2e713cd-cc36-4c0a-b5bd-b47cb8a0561e | |||
| dockerImageTag: 1.4.3 | |||
| dockerImageTag: 1.4.4 | |||
There was a problem hiding this comment.
We should do a minor version increase here
akashkulk
reviewed
Jul 26, 2024
| Collections.singletonList(AutoCloseableIterators.lazyIterator(incrementalIteratorSupplier, null)), | ||
| Collections.singletonList(initialSnapshotIterator), | ||
| cdcStreamsCompleteStatusEmitters, | ||
| List.of(new TransientErrorTraceEmitterIterator( |
There was a problem hiding this comment.
Let's remove the transient error trace emitters.
Context : #42421
akashkulk
reviewed
Jul 26, 2024
| cdcStreamsCompleteStatusEmitters).flatMap(Collection::stream).collect(Collectors.toList()), | ||
| AirbyteTraceMessageUtility::emitStreamStatusTrace)); | ||
| } else if (initialSnapshotIterators.isEmpty()) { | ||
| LOGGER.info("Initial load has finished completely - only reading the binlog"); |
There was a problem hiding this comment.
nit : oplog here and below
There was a problem hiding this comment.
good catch, fixed!
akashkulk
reviewed
Jul 26, 2024
...ngodb-v2/src/main/java/io/airbyte/integrations/source/mongodb/cdc/MongoDbCdcInitializer.java
Outdated
Show resolved
Hide resolved
akashkulk
reviewed
Jul 26, 2024
...ngodb-v2/src/main/java/io/airbyte/integrations/source/mongodb/cdc/MongoDbCdcInitializer.java
Outdated
Show resolved
Hide resolved
akashkulk
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/8730
Port of #38240 for MongoDB
We did some local tests by building a dev image and testing against our mongo atlas saas instance.