Destination Databricks: Handle table name casing correctly #44506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Aug 21, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/mixed_case_sqlgen_test
branch
2 times, most recently
from
5555212 to
6ae90f0
Compare
edgao
force-pushed
the
edgao/databricks_case_sensitivity
branch
3 times, most recently
from
d083ccd to
a2aa68f
Compare
edgao
force-pushed
the
edgao/mixed_case_sqlgen_test
branch
from
6ae90f0 to
7fc4b42
Compare
edgao
force-pushed
the
edgao/databricks_case_sensitivity
branch
2 times, most recently
from
c385050 to
ff0d3bd
Compare
gisripa
reviewed
Aug 22, 2024
| namingTransformer.getNamespace(namespace).lowercase(), | ||
| namingTransformer.getIdentifier(name).lowercase(), | ||
| namingTransformer.getNamespace(rawNamespaceOverride).lowercase(), | ||
| namingTransformer.getIdentifier(StreamId.concatenateRawTableName(namespace, name)).lowercase(), |
There was a problem hiding this comment.
This is where namingTransformer would've really helped if we had the methods separation correctly 😅 unfortunately getIdentifier is shared between columns and raw table name.
There was a problem hiding this comment.
yuuup. though it's kind of redundant with sqlgenerator making that split anyway 🤷 there's probably a world where we kill NamingTransformer and just do everything directly in sqlgenerator
gisripa
approved these changes
Aug 22, 2024
edgao
force-pushed
the
edgao/mixed_case_sqlgen_test
branch
2 times, most recently
from
8508c4d to
3edff7b
Compare
edgao
force-pushed
the
edgao/databricks_case_sensitivity
branch
from
ff0d3bd to
3a94916
Compare
octavia-squidington-iii
added
the
area/documentation
edgao
force-pushed
the
edgao/databricks_case_sensitivity
branch
from
3a94916 to
f34f593
Compare
edgao
force-pushed
the
edgao/databricks_case_sensitivity
branch
from
3de5d36 to
02e71aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on #44505 for the new test case. Verified that the test fails without the
.lowercase()stuff in this PR. Includes all the same changes as #42504 to upgrade to the newest CDK (I think the diff is reasonably clear, but lmk if you want me to split the cdk upgrade + bugfix to separate PRs)includes something similar to #44526 (i.e. don't actually fetch the gen ID). I could be convinced to just directly ship this wit the "only fetch gen ID during truncate sync" logic though.
(I also ran a sync locally with a mixed-case stream name, which succeeded with a dev image and failed with the mainline image)