Destinations bigquery+snowflake+redshift: hard revert refreshes thing #44526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
This was referenced Aug 21, 2024
gisripa
approved these changes
Aug 22, 2024
edgao
force-pushed
the
edgao/hard_revert_refreshes_stuff
branch
from
5c94292 to
5b4fa6a
Compare
octavia-squidington-iii
added
the
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop querying the db, just return
0for generation ID instead. This means that during truncate syncs, we will always assume the final table belongs to the wrong generation (i.e. equivalent to behavior from before https://github.com/airbytehq/airbyte-internal-issues/issues/8784). As a reminder, platform has a mitigation for this bug (https://github.com/airbytehq/airbyte-platform-internal/pull/13190 - only send the success status message if the source exits 0)Also disable the relevant test case for these destinations.