-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destination-snowflake: speed up metadata queries #45422
destination-snowflake: speed up metadata queries #45422
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on Graphite |
115827f
to
aed93b6
Compare
aed93b6
to
c972312
Compare
98467d3
to
dbe2fb1
Compare
765a6cc
to
ea13c79
Compare
dbe2fb1
to
108ff38
Compare
ea13c79
to
eb88eff
Compare
eb88eff
to
36f59f1
Compare
afe55f2
to
5e9b9c1
Compare
1a5341c
to
0aa0378
Compare
5e9b9c1
to
1a20860
Compare
0aa0378
to
a9d0815
Compare
1a20860
to
05cc92b
Compare
05cc92b
to
09fb99c
Compare
09fb99c
to
1b5edad
Compare
a9d0815
to
7c8d612
Compare
1b5edad
to
d2c938a
Compare
d2c938a
to
dfd8fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems convincing, feels a bit risky? (lmk if you disagree, I'm not familiar with how these queries behave)
maybe worth running a prerelease image just as a failsafe? (i.e. check that the sync succeeds + doesn't trigger a soft reset)
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt
Show resolved
Hide resolved
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt
Show resolved
Hide resolved
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt
Show resolved
Hide resolved
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt
Show resolved
Hide resolved
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt
Show resolved
Hide resolved
...otlin/io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeV1V2Migrator.kt
Show resolved
Hide resolved
Merge activity
|
What
This change improves the performance of metadata queries in the Snowflake destination connector by optimizing how table information is retrieved and processed.
How
information_schema
withSHOW TABLES
andDESCRIBE TABLE
commands for faster metadata retrieval. This should also reduce the cost for customers by reduce the use of warehousesgetFinalTableRowCount
,findExistingTables
, andgetTable
to use the new querying approachReview guide
SnowflakeDestinationHandler.kt
SnowflakeV1V2Migrator.kt
SnowflakeInternalStagingLowercaseDatabaseTypingDedupingTest.kt
User Impact
Users should experience faster sync operations, especially for connections with a large number of tables or columns. This optimization reduces the time spent on metadata queries, leading to improved overall performance.