destination-postgres: update all dependencies #45434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Sep 12, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
This was referenced Sep 12, 2024
This was referenced Sep 12, 2024
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
50199ea to
ad5f040
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
5439d2e to
16e4747
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
ad5f040 to
e17ac80
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
16e4747 to
15e74f8
Compare
This was referenced Sep 12, 2024
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
e17ac80 to
943e315
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
15e74f8 to
6e39eac
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
943e315 to
2c0f5d9
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
6e39eac to
b4396c4
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
2c0f5d9 to
2f07bd7
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
0845cbe to
92d2f4f
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
eb3c60d to
2b60177
Compare
octavia-squidington-iii
added
the
area/documentation
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
92d2f4f to
c375d1e
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
2b60177 to
803189a
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-java-cdks_update_all_libraries
branch
from
c375d1e to
2282aa3
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
803189a to
9c46f9f
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
9c46f9f to
301e235
Compare
stephane-airbyte
changed the base branch from
stephane/09-12-java-cdks_update_all_libraries
to
graphite-base/45434
stephane-airbyte
force-pushed
the
graphite-base/45434
branch
from
2282aa3 to
16b8d35
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
301e235 to
853d606
Compare
stephane-airbyte
changed the base branch from
graphite-base/45434
to
master
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
853d606 to
50f814b
Compare
edgao
approved these changes
Sep 18, 2024
| @@ -3,7 +3,7 @@ plugins { | |||
| } | |||
|
|
|||
| airbyteJavaConnector { | |||
| cdkVersionRequired = '0.44.3' | |||
| cdkVersionRequired = '0.46.0' | |||
| features = ['db-destinations', 'datastore-postgres', 'typing-deduping'] | |||
| useLocalCdk = false | |||
There was a problem hiding this comment.
nit: why not local cdk here as well? (or conversely, why not upgrade to 0.46.0 on strict-encrypt)
There was a problem hiding this comment.
because I'm lazy and forgot strict-encrypt
| @@ -62,6 +63,13 @@ protected JdbcCompatibleSourceOperations<?> getSourceOperations() { | |||
| return new PostgresSourceOperations(); | |||
| } | |||
|
|
|||
| @Disabled | |||
There was a problem hiding this comment.
can you add a comment explaining why this is disabled?
There was a problem hiding this comment.
it's failing everywhere right now, I think...
There was a problem hiding this comment.
I'm pretty sure this test passes on bigquery/redshift/snowflake? at least I recall bumping them to a newer cdk without needing to disable it
stephane-airbyte
force-pushed
the
stephane/09-12-destination-postgres_update_all_dependencies
branch
from
50f814b to
c9332ca
Compare
stephane-airbyte
deleted the
stephane/09-12-destination-postgres_update_all_dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?