[source-stripe] 🐛 bump cdk to 5.10.2 to stop using PrintBuffer due to record count mismatches #46327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
artem1205
approved these changes
Oct 3, 2024
bazarnov
approved these changes
Oct 3, 2024
|
/approve-regression-tests I re-ran tests on cloud to validate the checksum errors and things checked out
|
|
/approve-and-merge reason="unrelated breaking change migration documentation CI failure, this change is a trivial bump for an OC issue" |
brianjlai
commented
Oct 3, 2024
| @@ -49,7 +49,6 @@ | |||
| {"stream": "products", "data": {"id": "prod_KouQ5ez86yREmB", "object": "product", "active": true, "attributes": [], "created": 1640124902, "default_price": "price_1K9GbqEcXtiJtvvhJ3lZe4i5", "description": null, "features": [], "images": [], "livemode": false, "metadata": {}, "name": "edgao-test-product", "package_dimensions": null, "shippable": null, "statement_descriptor": null, "tax_code": "txcd_10000000", "type": "service", "unit_label": null, "updated": 1696839715, "url": null}, "emitted_at": 1697627307635} | |||
| {"stream": "products", "data": {"id": "prod_NHcKselSHfKdfc", "object": "product", "active": true, "attributes": [], "created": 1675345504, "default_price": "price_1MX364EcXtiJtvvhE3WgTl4O", "description": "Test Product 1 description", "features": [], "images": ["https://files.stripe.com/links/MDB8YWNjdF8xSndub2lFY1h0aUp0dnZofGZsX3Rlc3RfdjBOT09UaHRiNVl2WmJ6clNYRUlmcFFD00cCBRNHnV"], "livemode": false, "metadata": {}, "name": "Test Product 1", "package_dimensions": null, "shippable": null, "statement_descriptor": null, "tax_code": "txcd_10301000", "type": "service", "unit_label": null, "updated": 1696839789, "url": null}, "emitted_at": 1697627307877} | |||
| {"stream": "products", "data": {"id": "prod_NCgx1XP2IFQyKF", "object": "product", "active": true, "attributes": [], "created": 1674209524, "default_price": null, "description": null, "features": [], "images": [], "livemode": false, "metadata": {}, "name": "tu", "package_dimensions": null, "shippable": null, "statement_descriptor": null, "tax_code": "txcd_10000000", "type": "service", "unit_label": null, "updated": 1696839225, "url": null}, "emitted_at": 1697627307879} | |||
| {"stream":"subscriptions","data":{"id":"sub_1POL30EcXtiJtvvh4UdCl3kj","object":"subscription","application":null,"application_fee_percent":null,"automatic_tax":{"enabled":false,"liability":null},"billing_cycle_anchor":1717598562.0,"billing_cycle_anchor_config":null,"billing_thresholds":null,"cancel_at":null,"cancel_at_period_end":false,"canceled_at":null,"cancellation_details":{"comment":null,"feedback":null,"reason":null},"collection_method":"send_invoice","created":1717598562,"currency":"usd","current_period_end":1720622562.0,"current_period_start":1720017762,"customer":"cus_Kou8knsO3qQOwU","days_until_due":30,"default_payment_method":null,"default_source":null,"default_tax_rates":[],"description":null,"discount":{"id":"di_1POL31EcXtiJtvvhc8sEBzwi","object":"discount","checkout_session":null,"coupon":{"id":"4SUEGKZg","object":"coupon","amount_off":200.0,"created":1674209030,"currency":"usd","duration":"repeating","duration_in_months":3.0,"livemode":false,"max_redemptions":null,"metadata":{},"name":"Іекшзу","percent_off":null,"redeem_by":null,"times_redeemed":2.0,"valid":true},"customer":"cus_Kou8knsO3qQOwU","end":1725547362,"invoice":null,"invoice_item":null,"promotion_code":null,"start":1717598562,"subscription":"sub_1POL30EcXtiJtvvh4UdCl3kj","subscription_item":null},"discounts":["di_1POL31EcXtiJtvvhc8sEBzwi"],"ended_at":null,"invoice_settings":{"account_tax_ids":null,"issuer":{"type":"self"}},"items":{"object":"list","data":[{"id":"si_QEogVBC6jV71Ti","object":"subscription_item","billing_thresholds":null,"created":1717598563,"discounts":[],"metadata":{},"plan":{"id":"price_1PDtzkEcXtiJtvvhY4aqjMSq","object":"plan","active":true,"aggregate_usage":null,"amount":null,"amount_decimal":null,"billing_scheme":"tiered","created":1715111292,"currency":"usd","interval":"week","interval_count":1,"livemode":false,"metadata":{},"meter":null,"nickname":null,"product":"prod_Q423JP7oX7TF5U","tiers_mode":"graduated","transform_usage":null,"trial_period_days":null,"usage_type":"licensed"},"price":{"id":"price_1PDtzkEcXtiJtvvhY4aqjMSq","object":"price","active":true,"billing_scheme":"tiered","created":1715111292,"currency":"usd","custom_unit_amount":null,"livemode":false,"lookup_key":null,"metadata":{},"nickname":null,"product":"prod_Q423JP7oX7TF5U","recurring":{"aggregate_usage":null,"interval":"week","interval_count":1,"meter":null,"trial_period_days":null,"usage_type":"licensed"},"tax_behavior":"exclusive","tiers_mode":"graduated","transform_quantity":null,"type":"recurring","unit_amount":null,"unit_amount_decimal":null},"quantity":1,"subscription":"sub_1POL30EcXtiJtvvh4UdCl3kj","tax_rates":[]}],"has_more":false,"total_count":1.0,"url":"/v1/subscription_items?subscription=sub_1POL30EcXtiJtvvh4UdCl3kj"},"latest_invoice":"in_1PYUP7EcXtiJtvvhSPc5z2FG","livemode":false,"metadata":{},"next_pending_invoice_item_invoice":null,"on_behalf_of":null,"pause_collection":null,"payment_settings":{"payment_method_options":null,"payment_method_types":null,"save_default_payment_method":"off"},"pending_invoice_item_interval":null,"pending_setup_intent":null,"pending_update":null,"plan":{"id":"price_1PDtzkEcXtiJtvvhY4aqjMSq","object":"plan","active":true,"aggregate_usage":null,"amount":null,"amount_decimal":null,"billing_scheme":"tiered","created":1715111292,"currency":"usd","interval":"week","interval_count":1,"livemode":false,"metadata":{},"meter":null,"nickname":null,"product":"prod_Q423JP7oX7TF5U","tiers_mode":"graduated","transform_usage":null,"trial_period_days":null,"usage_type":"licensed"},"quantity":1,"schedule":null,"start_date":1717598562,"status":"past_due","test_clock":null,"transfer_data":null,"trial_end":null,"trial_settings":{"end_behavior":{"missing_payment_method":"create_invoice"}},"trial_start":null,"updated":1717598562},"emitted_at":1720515564910} | |||
There was a problem hiding this comment.
i have no idea why this record got removed from our stripe account, but I couldn't retrieve it listing subscriptions via http requests and trying the direct request using the id using https://api.stripe.com/v1/subscriptions/sub_1MowQVLkdIwHu7ixeRlqHVzs, resulted in a 404, so I don't believe it exists anymore.
This was passing last night/this morning so i'm convinced this isn't an issue with my changes
|
/approve-regression-tests lets try this again. already checked in cloud
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The CDK was updated in
5.10.2to not haveentrypoint.pyuse the PrintBuffer. I tested this against a pre-release version which appear to get rid of the mismatches. This is just the bump ofsource-stripeto update the changeUser Impact
n/a
Can this PR be safely reverted and rolled back?