Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-stripe] 🐛 bump cdk to 5.10.2 to stop using PrintBuffer due to record count mismatches #46327

Merged
merged 7 commits into from
Oct 4, 2024
Merged

[source-stripe] 🐛 bump cdk to 5.10.2 to stop using PrintBuffer due to record count mismatches #46327

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2584902
bump cdk to 5.10.2 to stop using PrintBuffer due to record count mism…
brianjlai Oct 3, 2024
c3f8465
update changelog now that I have the PR number
brianjlai Oct 3, 2024
a88fe4d
Merge branch 'master' into brian/stripe_update_cdk_to_remove_print_bu…
brianjlai Oct 3, 2024
602ab41
modify the migration guide to pass ci checks...
brianjlai Oct 3, 2024
ad1af83
remove expected subscription record that no longer exists in the api
brianjlai Oct 3, 2024
14bbdf9
update acceptance-test-config with empty spring
brianjlai Oct 3, 2024
16ba7bb
make it stop its missing records all the way down
brianjlai Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion airbyte-integrations/connectors/source-stripe/integration_tests/expected_records.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
{"stream": "products", "data": {"id": "prod_KouQ5ez86yREmB", "object": "product", "active": true, "attributes": [], "created": 1640124902, "default_price": "price_1K9GbqEcXtiJtvvhJ3lZe4i5", "description": null, "features": [], "images": [], "livemode": false, "metadata": {}, "name": "edgao-test-product", "package_dimensions": null, "shippable": null, "statement_descriptor": null, "tax_code": "txcd_10000000", "type": "service", "unit_label": null, "updated": 1696839715, "url": null}, "emitted_at": 1697627307635}
{"stream": "products", "data": {"id": "prod_NHcKselSHfKdfc", "object": "product", "active": true, "attributes": [], "created": 1675345504, "default_price": "price_1MX364EcXtiJtvvhE3WgTl4O", "description": "Test Product 1 description", "features": [], "images": ["https://files.stripe.com/links/MDB8YWNjdF8xSndub2lFY1h0aUp0dnZofGZsX3Rlc3RfdjBOT09UaHRiNVl2WmJ6clNYRUlmcFFD00cCBRNHnV"], "livemode": false, "metadata": {}, "name": "Test Product 1", "package_dimensions": null, "shippable": null, "statement_descriptor": null, "tax_code": "txcd_10301000", "type": "service", "unit_label": null, "updated": 1696839789, "url": null}, "emitted_at": 1697627307877}
{"stream": "products", "data": {"id": "prod_NCgx1XP2IFQyKF", "object": "product", "active": true, "attributes": [], "created": 1674209524, "default_price": null, "description": null, "features": [], "images": [], "livemode": false, "metadata": {}, "name": "tu", "package_dimensions": null, "shippable": null, "statement_descriptor": null, "tax_code": "txcd_10000000", "type": "service", "unit_label": null, "updated": 1696839225, "url": null}, "emitted_at": 1697627307879}
{"stream":"subscriptions","data":{"id":"sub_1POL30EcXtiJtvvh4UdCl3kj","object":"subscription","application":null,"application_fee_percent":null,"automatic_tax":{"enabled":false,"liability":null},"billing_cycle_anchor":1717598562.0,"billing_cycle_anchor_config":null,"billing_thresholds":null,"cancel_at":null,"cancel_at_period_end":false,"canceled_at":null,"cancellation_details":{"comment":null,"feedback":null,"reason":null},"collection_method":"send_invoice","created":1717598562,"currency":"usd","current_period_end":1720622562.0,"current_period_start":1720017762,"customer":"cus_Kou8knsO3qQOwU","days_until_due":30,"default_payment_method":null,"default_source":null,"default_tax_rates":[],"description":null,"discount":{"id":"di_1POL31EcXtiJtvvhc8sEBzwi","object":"discount","checkout_session":null,"coupon":{"id":"4SUEGKZg","object":"coupon","amount_off":200.0,"created":1674209030,"currency":"usd","duration":"repeating","duration_in_months":3.0,"livemode":false,"max_redemptions":null,"metadata":{},"name":"Іекшзу","percent_off":null,"redeem_by":null,"times_redeemed":2.0,"valid":true},"customer":"cus_Kou8knsO3qQOwU","end":1725547362,"invoice":null,"invoice_item":null,"promotion_code":null,"start":1717598562,"subscription":"sub_1POL30EcXtiJtvvh4UdCl3kj","subscription_item":null},"discounts":["di_1POL31EcXtiJtvvhc8sEBzwi"],"ended_at":null,"invoice_settings":{"account_tax_ids":null,"issuer":{"type":"self"}},"items":{"object":"list","data":[{"id":"si_QEogVBC6jV71Ti","object":"subscription_item","billing_thresholds":null,"created":1717598563,"discounts":[],"metadata":{},"plan":{"id":"price_1PDtzkEcXtiJtvvhY4aqjMSq","object":"plan","active":true,"aggregate_usage":null,"amount":null,"amount_decimal":null,"billing_scheme":"tiered","created":1715111292,"currency":"usd","interval":"week","interval_count":1,"livemode":false,"metadata":{},"meter":null,"nickname":null,"product":"prod_Q423JP7oX7TF5U","tiers_mode":"graduated","transform_usage":null,"trial_period_days":null,"usage_type":"licensed"},"price":{"id":"price_1PDtzkEcXtiJtvvhY4aqjMSq","object":"price","active":true,"billing_scheme":"tiered","created":1715111292,"currency":"usd","custom_unit_amount":null,"livemode":false,"lookup_key":null,"metadata":{},"nickname":null,"product":"prod_Q423JP7oX7TF5U","recurring":{"aggregate_usage":null,"interval":"week","interval_count":1,"meter":null,"trial_period_days":null,"usage_type":"licensed"},"tax_behavior":"exclusive","tiers_mode":"graduated","transform_quantity":null,"type":"recurring","unit_amount":null,"unit_amount_decimal":null},"quantity":1,"subscription":"sub_1POL30EcXtiJtvvh4UdCl3kj","tax_rates":[]}],"has_more":false,"total_count":1.0,"url":"/v1/subscription_items?subscription=sub_1POL30EcXtiJtvvh4UdCl3kj"},"latest_invoice":"in_1PYUP7EcXtiJtvvhSPc5z2FG","livemode":false,"metadata":{},"next_pending_invoice_item_invoice":null,"on_behalf_of":null,"pause_collection":null,"payment_settings":{"payment_method_options":null,"payment_method_types":null,"save_default_payment_method":"off"},"pending_invoice_item_interval":null,"pending_setup_intent":null,"pending_update":null,"plan":{"id":"price_1PDtzkEcXtiJtvvhY4aqjMSq","object":"plan","active":true,"aggregate_usage":null,"amount":null,"amount_decimal":null,"billing_scheme":"tiered","created":1715111292,"currency":"usd","interval":"week","interval_count":1,"livemode":false,"metadata":{},"meter":null,"nickname":null,"product":"prod_Q423JP7oX7TF5U","tiers_mode":"graduated","transform_usage":null,"trial_period_days":null,"usage_type":"licensed"},"quantity":1,"schedule":null,"start_date":1717598562,"status":"past_due","test_clock":null,"transfer_data":null,"trial_end":null,"trial_settings":{"end_behavior":{"missing_payment_method":"create_invoice"}},"trial_start":null,"updated":1717598562},"emitted_at":1720515564910}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no idea why this record got removed from our stripe account, but I couldn't retrieve it listing subscriptions via http requests and trying the direct request using the id using https://api.stripe.com/v1/subscriptions/sub_1MowQVLkdIwHu7ixeRlqHVzs, resulted in a 404, so I don't believe it exists anymore.

This was passing last night/this morning so i'm convinced this isn't an issue with my changes

{"stream":"subscription_schedule","data":{"id":"sub_sched_1PVzF9EcXtiJtvvhbyFup9qG","object":"subscription_schedule","application":null,"canceled_at":null,"completed_at":null,"created":1719421371,"current_phase":null,"customer":"cus_OV79K86ov5FMFM","default_settings":{"application_fee_percent":null,"automatic_tax":{"enabled":false,"liability":null},"billing_cycle_anchor":"automatic","billing_thresholds":null,"collection_method":"charge_automatically","default_payment_method":null,"default_source":null,"description":null,"invoice_settings":"{'account_tax_ids': None, 'days_until_due': None, 'issuer': {'type': 'self'}}","on_behalf_of":null,"transfer_data":null},"end_behavior":"cancel","livemode":false,"metadata":{},"phases":[{"add_invoice_items":[],"application_fee_percent":null,"billing_cycle_anchor":null,"billing_thresholds":null,"collection_method":null,"coupon":"4SUEGKZg","currency":"usd","default_payment_method":null,"default_tax_rates":[],"description":null,"discounts":[{"coupon":"4SUEGKZg","discount":null,"promotion_code":null}],"end_date":1727654400,"invoice_settings":"{'account_tax_ids': None, 'days_until_due': None, 'issuer': None}","items":[{"billing_thresholds":null,"discounts":[],"metadata":{},"plan":"price_1MSHZoEcXtiJtvvh6O8TYD8T","price":"price_1MSHZoEcXtiJtvvh6O8TYD8T","quantity":1,"tax_rates":[]}],"metadata":{},"on_behalf_of":null,"proration_behavior":"none","start_date":1724976000,"transfer_data":null,"trial_end":null}],"released_at":null,"released_subscription":null,"renewal_interval":null,"status":"not_started","subscription":null,"test_clock":null,"updated":1719421371},"emitted_at":1720516126323}
{"stream": "transfers", "data": {"id": "tr_1NH18zEcXtiJtvvhnd827cNO", "object": "transfer", "amount": 10000, "amount_reversed": 0, "balance_transaction": "txn_1NH190EcXtiJtvvhBO3PeR7p", "created": 1686301085, "currency": "usd", "description": null, "destination": "acct_1Jx8unEYmRTj5on1", "destination_payment": "py_1NH18zEYmRTj5on1GkCCsqLK", "livemode": false, "metadata": {}, "reversals": {"object": "list", "data": [], "has_more": false, "total_count": 0.0, "url": "/v1/transfers/tr_1NH18zEcXtiJtvvhnd827cNO/reversals"}, "reversed": false, "source_transaction": null, "source_type": "card", "transfer_group": null, "updated": 1686301085}, "emitted_at": 1697627313262}
{"stream": "transfers", "data": {"id": "tr_1NGoaCEcXtiJtvvhjmHtOGOm", "object": "transfer", "amount": 100, "amount_reversed": 100, "balance_transaction": "txn_1NGoaDEcXtiJtvvhsZrNMsdJ", "created": 1686252800, "currency": "usd", "description": null, "destination": "acct_1Jx8unEYmRTj5on1", "destination_payment": "py_1NGoaCEYmRTj5on1LAlAIG3a", "livemode": false, "metadata": {}, "reversals": {"object": "list", "data": [{"id": "trr_1NGolCEcXtiJtvvhOYPck3CP", "object": "transfer_reversal", "amount": 100, "balance_transaction": "txn_1NGolCEcXtiJtvvhZRy4Kd5S", "created": 1686253482, "currency": "usd", "destination_payment_refund": "pyr_1NGolBEYmRTj5on1STal3rmp", "metadata": {}, "source_refund": null, "transfer": "tr_1NGoaCEcXtiJtvvhjmHtOGOm"}], "has_more": false, "total_count": 1.0, "url": "/v1/transfers/tr_1NGoaCEcXtiJtvvhjmHtOGOm/reversals"}, "reversed": true, "source_transaction": null, "source_type": "card", "transfer_group": "ORDER10", "updated": 1686252800}, "emitted_at": 1697627313264}
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-stripe/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: e094cb9a-26de-4645-8761-65c0c425d1de
dockerImageTag: 5.6.0
dockerImageTag: 5.6.1
dockerRepository: airbyte/source-stripe
documentationUrl: https://docs.airbyte.com/integrations/sources/stripe
erdUrl: https://dbdocs.io/airbyteio/source-stripe?view=relationships
Expand Down
Loading
Loading