metadata-service[lib]: validate that release candidate have rc suffix in their version #46573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
|
Testing the change on |
alafanechere
force-pushed
the
augustin/10-08-metadata-service_lib_validate_that_release_candidate_have_rc_suffix_in_their_version
branch
2 times, most recently
from
a0fcc33 to
0296422
Compare
octavia-squidington-iii
added
connectors/source/faker
area/connectors
2 tasks
alafanechere
force-pushed
the
augustin/10-08-metadata-service_lib_validate_that_release_candidate_have_rc_suffix_in_their_version
branch
from
0296422 to
3d5bcfa
Compare
clnoll
approved these changes
Oct 9, 2024
| if not has_rc_suffix: | ||
| return ( | ||
| False, | ||
| "The dockerImageTag field should end with -rc as the connector is marked as a release candidate (releases.isReleaseCandidate).", |
There was a problem hiding this comment.
Suggested change
| "The dockerImageTag field should end with -rc as the connector is marked as a release candidate (releases.isReleaseCandidate).", | |
| "The dockerImageTag field should have an -rc.<RC #> suffix as the connector is marked as a release candidate (releases.isReleaseCandidate). Example: 2.1.0-rc.1", |
Just wanted it to be clear that there should be an rc number at the end, too.
alafanechere
force-pushed
the
augustin/10-08-metadata-service_lib_validate_that_release_candidate_have_rc_suffix_in_their_version
branch
2 times, most recently
from
1d7193a to
f0c71ef
Compare
… in their version
alafanechere
force-pushed
the
augustin/10-08-metadata-service_lib_validate_that_release_candidate_have_rc_suffix_in_their_version
branch
from
f0c71ef to
1a998df
Compare
alafanechere
deleted the
augustin/10-08-metadata-service_lib_validate_that_release_candidate_have_rc_suffix_in_their_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Relates to https://github.com/airbytehq/airbyte-internal-issues/issues/10211
Add a metadata validator to ensure that a connector with the
releases.isReleaseCandidateflag set totruehas arcsuffix in its version.