airbyte-ci: add rc bump type to bump version
#46709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
2 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/10-08-airbyte-ci_rework_RC_promotion
branch
from
5db8b0d to
81f1b5c
Compare
alafanechere
force-pushed
the
augustin/10-10-airbyte-ci_add_rc_bump_type_to_bump_version
branch
from
58ebaaa to
73558be
Compare
alafanechere
force-pushed
the
augustin/10-10-airbyte-ci_add_rc_bump_type_to_bump_version
branch
2 times, most recently
from
9c08f64 to
5890181
Compare
alafanechere
force-pushed
the
augustin/10-10-airbyte-ci_add_rc_bump_type_to_bump_version
branch
from
5890181 to
f5a5d3d
Compare
alafanechere
force-pushed
the
augustin/10-08-airbyte-ci_rework_RC_promotion
branch
from
0189a00 to
2ddecef
Compare
alafanechere
force-pushed
the
augustin/10-10-airbyte-ci_add_rc_bump_type_to_bump_version
branch
from
f5a5d3d to
d128383
Compare
alafanechere
force-pushed
the
augustin/10-08-airbyte-ci_rework_RC_promotion
branch
from
2ddecef to
8e6a057
Compare
alafanechere
force-pushed
the
augustin/10-10-airbyte-ci_add_rc_bump_type_to_bump_version
branch
from
d128383 to
a19d9f9
Compare
Base automatically changed from
augustin/10-08-airbyte-ci_rework_RC_promotion
to
master
October 14, 2024 16:27
natikgadzhi
reviewed
Oct 14, 2024
| return isinstance(node, str) and node.startswith("#/") | ||
|
|
||
| @staticmethod | ||
| def _is_ref_key(key: str) -> bool: | ||
| return bool(key == REF_TAG) | ||
|
|
||
| @staticmethod | ||
| def _read_ref_value(ref: str, manifest_node: Mapping[str, Any]) -> Any: | ||
| def _read_ref_value(ref: str, manifest_node: Mapping[str, Any]) -> Any: # noqa: ANN401 |
There was a problem hiding this comment.
Should we change the linter rules instead?
There was a problem hiding this comment.
No, we should more accurately type this module 😄
alafanechere
force-pushed
the
augustin/10-10-airbyte-ci_add_rc_bump_type_to_bump_version
branch
from
a19d9f9 to
d68f244
Compare
alafanechere
deleted the
augustin/10-10-airbyte-ci_add_rc_bump_type_to_bump_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We want the bump version command to now allow RC bump type.
If you want to release a release candidate version you would:
-rc.1suffixrcnumber-rc.1>-rc.2