-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate Iceberg writers #48570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a few assorted comments/questions, but this generally makes sense!
...erg-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergStreamLoader.kt
Outdated
Show resolved
Hide resolved
...erg-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergStreamLoader.kt
Show resolved
Hide resolved
...-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/io/IcebergTableCleaner.kt
Outdated
Show resolved
Hide resolved
...quet/src/main/kotlin/io/airbyte/cdk/load/data/iceberg/parquet/AirbyteValueToIcebergRecord.kt
Show resolved
Hide resolved
...-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/io/IcebergTableCleaner.kt
Outdated
Show resolved
Hide resolved
...-iceberg-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/io/IcebergUtil.kt
Outdated
Show resolved
Hide resolved
...-iceberg-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/io/IcebergUtil.kt
Show resolved
Hide resolved
...-iceberg-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/io/IcebergUtil.kt
Show resolved
Hide resolved
...g-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/io/PartitionedWriters.kt
Show resolved
Hide resolved
...ceberg-v2/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/io/RecordWrapper.kt
Outdated
Show resolved
Hide resolved
…n/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergStreamLoader.kt Co-authored-by: Edward Gao <edward.gao@airbyte.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgao the |
Co-authored-by: subodhchaturvedi <subodh1810@gmail.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: subodhchaturvedi <subodh1810@gmail.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io>
What
How
DestinationWriter
so that it uses the Iceberg writersServerLoader
so that it uses the Iceberg writersThis PR contains the changes found in #48558
Review guide
IcebergV2Writer.kt
IcebergStreamLoader.kt
Can this PR be safely reverted and rolled back?