Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Iceberg writers #48570

Merged
merged 53 commits into from
Nov 21, 2024

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Integrate the Iceberg writers with the CDK writer/service loader API

How

  • Implement the CDK DestinationWriter so that it uses the Iceberg writers
  • Implement the CDK ServerLoader so that it uses the Iceberg writers
  • Remove unused/unnecessary classes

This PR contains the changes found in #48558

Review guide

  1. IcebergV2Writer.kt
  2. IcebergStreamLoader.kt

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a few assorted comments/questions, but this generally makes sense!

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@subodh1810
Copy link
Contributor

subodh1810 commented Nov 21, 2024

@edgao the IcebergV2SpecTest seems to fail since we pulled in latest master, can you take a look once

@subodh1810 subodh1810 merged commit 660d683 into master Nov 21, 2024
32 of 33 checks passed
@subodh1810 subodh1810 deleted the jonathan/implement-iceberg-stream-loader branch November 21, 2024 17:33
tryangul pushed a commit that referenced this pull request Nov 21, 2024
Co-authored-by: subodhchaturvedi <subodh1810@gmail.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
matteogp pushed a commit that referenced this pull request Nov 22, 2024
Co-authored-by: subodhchaturvedi <subodh1810@gmail.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/iceberg-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants