-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testMidSyncCheckpointingStreamState to be usable again #48583
Update testMidSyncCheckpointingStreamState to be usable again #48583
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@frifriSF59 You'll want to rerun the formatter |
I can confirm that these tests are less bad than before (they actually finish :) ) You'll need to rebase to pick up the config changes to get CI to pass (and re-pull your credentials locally) EDIT I lied, json is still failing for me locally... |
This fixes everything except staging. I need to test that better anyway if you want to leave that one disabled, I can follow up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's take some time today and I'll walk you through all our release processes
(technically there's no runtime code change here, so we don't need to release anything... but might as well :P )
.../load/src/testFixtures/kotlin/io/airbyte/cdk/load/write/BasicFunctionalityIntegrationTest.kt
Outdated
Show resolved
Hide resolved
811330c
to
14444b8
Compare
14444b8
to
822862e
Compare
closing in favor of #48610. Mostly the same changes, but refactored so that other tests can also use the same logic. |
What
Update testMidSyncCheckpointingStreamState to have the following flow:
I also removed
Disabled
decorators to reenable that testCloses https://github.com/airbytehq/airbyte-internal-issues/issues/10413
Can this PR be safely reverted and rolled back?