Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testMidSyncCheckpointingStreamState to be usable again #48583

Conversation

frifriSF59
Copy link
Contributor

What

Update testMidSyncCheckpointingStreamState to have the following flow:

  • Produce 1 record and 1 state message
  • .kill the destination
  • Run a normal sync
  • Ensure that the record produce above was indeed commited

I also removed Disabled decorators to reenable that test

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/10413

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@frifriSF59 frifriSF59 self-assigned this Nov 20, 2024
@frifriSF59 frifriSF59 requested a review from a team as a code owner November 20, 2024 23:38
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 9:08pm

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@frifriSF59 frifriSF59 changed the title Update testMidSyncCheckpointingStreamState to be ussable again Update testMidSyncCheckpointingStreamState to be usable again Nov 20, 2024
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3-v2 labels Nov 20, 2024
@johnny-schmidt
Copy link
Contributor

@frifriSF59 You'll want to rerun the formatter airbyte-ci format fix all

@johnny-schmidt
Copy link
Contributor

johnny-schmidt commented Nov 21, 2024

I can confirm that these tests are less bad than before (they actually finish :) )

You'll need to rebase to pick up the config changes to get CI to pass (and re-pull your credentials locally)

EDIT I lied, json is still failing for me locally...

@johnny-schmidt
Copy link
Contributor

This fixes everything except staging. I need to test that better anyway if you want to leave that one disabled, I can follow up

#48591

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's take some time today and I'll walk you through all our release processes

(technically there's no runtime code change here, so we don't need to release anything... but might as well :P )

@frifriSF59 frifriSF59 force-pushed the frifri/checkpoint-test-not-bad branch from 811330c to 14444b8 Compare November 21, 2024 20:39
@frifriSF59 frifriSF59 requested a review from a team as a code owner November 21, 2024 20:39
@frifriSF59 frifriSF59 changed the base branch from master to jschmidt/bulk-load/tolerate-empty-streams-batches November 21, 2024 21:05
@edgao edgao force-pushed the frifri/checkpoint-test-not-bad branch from 14444b8 to 822862e Compare November 21, 2024 21:08
@edgao
Copy link
Contributor

edgao commented Nov 22, 2024

closing in favor of #48610. Mostly the same changes, but refactored so that other tests can also use the same logic.

@edgao edgao closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants