Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Load CDK: Tolerate empty streams and update on empty batches #48591

Merged

Conversation

johnny-schmidt
Copy link
Contributor

What

I found this fixing legacy DATs but am pulling it out because it's breaking some of @frifriSF59 's attempted test fixes.

  • skips processing empty spill files to avoid cryptic XML AWS errors
  • pushes a dummy batch update to force state update anyway (@benmoriceau this is similar to your issue; we should break out a new event so this is less hacky)
  • treats a fully processed empty stream as ipso facto complete
  • tests

@johnny-schmidt johnny-schmidt requested a review from a team as a code owner November 21, 2024 01:40
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 4:46pm

@johnny-schmidt johnny-schmidt force-pushed the jschmidt/bulk-load/tolerate-empty-streams-batches branch from ac3992e to f738e9a Compare November 21, 2024 16:46
@johnny-schmidt johnny-schmidt merged commit 508b76f into master Nov 22, 2024
28 of 29 checks passed
@johnny-schmidt johnny-schmidt deleted the jschmidt/bulk-load/tolerate-empty-streams-batches branch November 22, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants