Inline code uses correct color in a table's header row #49828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-at-airbyte
requested review from
marcosmarxm,
nataliekwong and
letiescanciano
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -261,7 +261,9 @@ table tr:last-child td:last-child { | |||
| border-bottom-right-radius: 10px; | |||
| } | |||
|
|
|||
|
|
|||
| table th code { | |||
| color: var(--ifm-color-content); | |||
There was a problem hiding this comment.
@ian-at-airbyte would it make sense to also remove the background? feels weird to have a background on the header like that
There was a problem hiding this comment.
I experimented with this a bit. The main drawback when removing the background is it becomes more difficult to notice that this is code font. Given it's rare to use code font in this way, I think I'm going to assume authors who do this want the text to be quite obviously code font.
letiescanciano
approved these changes
Dec 17, 2024
ian-at-airbyte
deleted the
docs-fix-code-color-in-table-heading-cells
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an edge case where inline code in table header cells used the wrong font color, which made that font illegible.
Before:
After:
How
Minor CSS update
Review guide
integrations/destinations/r2#csv - check the color of text in table headings. It should be legible both as regular text and as inline code, both in light and dark mode.
User Impact
Unreadable text is now readable.
Can this PR be safely reverted and rolled back?