Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code uses correct color in a table's header row #49828

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Inline code uses correct color in a table's header row #49828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docusaurus/src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,9 @@ table tr:last-child td:last-child {
border-bottom-right-radius: 10px;
}


table th code {
color: var(--ifm-color-content);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ian-at-airbyte would it make sense to also remove the background? feels weird to have a background on the header like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I experimented with this a bit. The main drawback when removing the background is it becomes more difficult to notice that this is code font. Given it's rare to use code font in this way, I think I'm going to assume authors who do this want the text to be quite obviously code font.

}

table td code {
background-color: var(--color-blue-30);
Expand Down
Loading