Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Zendesk Support: fix incremental logic for ticket_comments stream #5787

Merged
merged 16 commits into from
Sep 9, 2021
Merged

🐛 Source Zendesk Support: fix incremental logic for ticket_comments stream #5787

merged 16 commits into from
Sep 9, 2021

Conversation

antixar
Copy link
Contributor

@antixar antixar commented Sep 1, 2021 •
edited
Loading

What

For loading of all comments this connector needs a list of all updated tickets. But the stream tickets have different cursor formats e.g:

Ticket state "generated_timestamp": 1627637409}
Comment state: {"created_at": "2021-07-30T12:30:09Z"}

the old conversion between them was incorrect because the connector had to know a user timezone.

Recommended reading order

  1. streams.py

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@antixar antixar self-assigned this Sep 1, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 1, 2021
@antixar antixar linked an issue Sep 1, 2021 that may be closed by this pull request
Zendesk Support Connector successful sync but result in retry #5695
Closed
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 1, 2021
@antixar
Copy link
Contributor Author

antixar commented Sep 1, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1191948818
❌ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1191948818

@jrhizor jrhizor temporarily deployed to more-secrets September 1, 2021 21:55 Inactive
@antixar
Copy link
Contributor Author

antixar commented Sep 1, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1191998808
✅ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1191998808

@jrhizor jrhizor temporarily deployed to more-secrets September 1, 2021 22:14 Inactive
@antixar
Copy link
Contributor Author

antixar commented Sep 2, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1195632266
❌ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1195632266

@jrhizor jrhizor temporarily deployed to more-secrets September 2, 2021 20:22 Inactive
@antixar
Copy link
Contributor Author

antixar commented Sep 3, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1197738961
❌ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1197738961

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 11:04 Inactive
@antixar
Copy link
Contributor Author

antixar commented Sep 3, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1199628218
❌ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1199628218

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 22:51 Inactive
@antixar antixar requested a review from Phlair September 6, 2021 15:44
midavadim
midavadim reviewed Sep 6, 2021
View reviewed changes
Copy link
Contributor

@midavadim midavadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the main part of the update which solves the problem?

...yte-integrations/connectors/source-zendesk-support/source_zendesk_support/schemas/users.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py Show resolved Hide resolved
@antixar
Copy link
Contributor Author

antixar commented Sep 8, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1212774999
❌ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1212774999

@jrhizor jrhizor temporarily deployed to more-secrets September 8, 2021 09:35 Inactive
@Phlair Phlair changed the title 🐛 Source Zendesk Support: retry sync 🐛 Source Zendesk Support: fix incremental logic for ticket_comments stream Sep 8, 2021
Phlair
Phlair reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll wait for tests to pass before approve.

Just some very minor comments

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py Outdated Show resolved Hide resolved
...rations/connectors/source-zendesk-support/source_zendesk_support/schemas/ticket_metrics.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py Show resolved Hide resolved
@antixar
Copy link
Contributor Author

antixar commented Sep 8, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1215243368
❌ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1215243368

@jrhizor jrhizor temporarily deployed to more-secrets September 8, 2021 23:11 Inactive
@antixar
Copy link
Contributor Author

antixar commented Sep 8, 2021 •
edited by github-actions bot
Loading

/test connector=source-zendesk-support

🕑 source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1215287745
✅ source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1215287745

@jrhizor jrhizor temporarily deployed to more-secrets September 8, 2021 23:31 Inactive
@antixar antixar requested a review from Phlair September 9, 2021 05:56
Phlair
Phlair approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

...rations/connectors/source-zendesk-support/source_zendesk_support/schemas/ticket_metrics.json Show resolved Hide resolved
@antixar
Copy link
Contributor Author

antixar commented Sep 9, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1217071308
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1217071308

@jrhizor jrhizor temporarily deployed to more-secrets September 9, 2021 11:19 Inactive
@antixar antixar merged commit 984cebe into master Sep 9, 2021
@antixar antixar deleted the antixar/5695-zendesk-support-sync-retry branch September 9, 2021 11:55
@jrhizor jrhizor mentioned this pull request Sep 16, 2021
Merged
@danieldiamond danieldiamond mentioned this pull request Sep 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midavadim midavadim midavadim left review comments

@lazebnyi lazebnyi lazebnyi approved these changes

@Phlair Phlair Phlair approved these changes

Assignees

@antixar antixar

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zendesk Support Connector successful sync but result in retry
6 participants
@antixar @midavadim @Phlair @lazebnyi @jrhizor @gl-pix