add instancewide variables setter endpoints #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle injection for check/discover jobs too
sherifnada
changed the title
github-actions
bot
added
area/api
github-actions
bot
removed
CDK
Comment on lines
+3004
to
+3012
| required: | ||
| - sourceConnectorDefinitionId | ||
| - params | ||
| properties: | ||
| sourceDefinitionId: | ||
| $ref: "#/components/schemas/SourceDefinitionId" | ||
| params: | ||
| type: object | ||
| additionalProperties: true |
There was a problem hiding this comment.
If we also add workspaceId as an optional properties (not required), we can also handle setting workspace specific parameters.
Thus, I wouldn't include the instanceWide in the naming
There was a problem hiding this comment.
I am intentionally including this so that endpoint permissioning is possible without having to inspect the body of the request i.e: I want to make this whole endpoint available only to super admins rather than depending on whether workspace ID is passed, make it available to different permission levels. WDYT?
There was a problem hiding this comment.
Ok that makes sense!
|
@ChristopheDuong gonna move forward on this but please add any further comments and I'll address them as soon as I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #5920
How
Adds an endpoint which allows writing instancewide oauth secrets
Recommended reading order
config.yamlOauthHandler.java&OauthHandlerTest.javaConfigurationApi.java