-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add instancewide variables setter endpoints #5940
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e17bd6c
Add a config for instance wide oauth parameters
ChristopheDuong a6128c5
Remove recreate endpoints and add tests
ChristopheDuong c196c98
Remove webbackend endpoints
ChristopheDuong 6fdefce
Scheduler injects oauth Parameters
ChristopheDuong d4184d3
Refactor JsonNode merge
ChristopheDuong 345ea46
Remove comment
ChristopheDuong 087b149
Merge remote-tracking branch 'origin/master' into oauth-params
ChristopheDuong 44747c5
Clean up recreate endpoints
ChristopheDuong c970466
Inject oauth params in discover/check/reset too
ChristopheDuong e25cd47
make source-bigquery compile
ChristopheDuong 42d8425
Revert injecting in DefaultJobCreator back to DefaultSyncJobFactory
ChristopheDuong 2cd5617
Merge remote-tracking branch 'origin/master' into oauth-params
ChristopheDuong 340f79d
Format code
ChristopheDuong d8e3d83
conflict
sherifnada a529a13
impl
sherifnada ea7d992
conflict
sherifnada ef871a5
Merge branch 'chris/oauth-params' into sherif/add-instancewide-setter…
sherifnada c2eaf28
change endpoint names
sherifnada d294220
include platform build by default
sherifnada d1b7434
conflict
sherifnada 9e387e0
fmt
sherifnada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
airbyte-integrations/connectors/source-github/fixtures/main.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we also add
workspaceId
as an optional properties (not required), we can also handle setting workspace specific parameters.Thus, I wouldn't include the
instanceWide
in the namingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am intentionally including this so that endpoint permissioning is possible without having to inspect the body of the request i.e: I want to make this whole endpoint available only to super admins rather than depending on whether workspace ID is passed, make it available to different permission levels. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that makes sense!