🐛 Fix minor bugs. #6188
Merged
🐛 Fix minor bugs. #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of when they the log file is retrieved.
davinchia
commented
Sep 17, 2021
.github/workflows/helm.yaml
Outdated
| @@ -2,73 +2,73 @@ name: Helm | |||
| on: | |||
| push: | |||
| paths: | |||
| - '.github/workflows/helm.yaml' | |||
| - 'charts/**' | |||
| - ".github/workflows/helm.yaml" | |||
davinchia
commented
Sep 17, 2021
| @@ -70,7 +70,8 @@ def createSpotlessTarget = { pattern -> | |||
| 'dbt_schema_tests', | |||
| 'normalization_test_output', | |||
| 'tools', | |||
| 'secrets' | |||
| 'secrets', | |||
| 'charts' // Helm charts often have injected template strings that will fail general linting. Helm linting is done separately. | |||
There was a problem hiding this comment.
ignore helm when running format.
davinchia
commented
Sep 17, 2021
| if (jobsScheduledCount > 0) { | ||
| LOGGER.info("Job-Scheduler Summary. Active connections: {}, Jobs scheduler: {}", activeConnections.size(), jobsScheduled.get()); | ||
|
|
||
| if (jobsScheduled > 0) { |
There was a problem hiding this comment.
@tuliren looks like you were the last person to touch this - do these changes preserve the intent? I'm somewhat guessing here :)
There was a problem hiding this comment.
I think so. The purpose of my change is to only creating this log if there are non zero jobs scheduled. This should still work.
davinchia
commented
Sep 17, 2021
| LOGGER.debug("Setting docker job mdc"); | ||
| MDC.put(LogClientSingleton.JOB_LOG_PATH_MDC_KEY, path.resolve(LogClientSingleton.LOG_FILENAME).toString()); | ||
| } else { | ||
| LOGGER.debug("Setting kube job mdc"); | ||
| var logConfigs = new LogConfigDelegator(configs); |
There was a problem hiding this comment.
by always creating the client at the beginning, we make sure this errors out on start up.
tuliren
approved these changes
Sep 17, 2021
jrhizor
approved these changes
Sep 17, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Recommended reading order
LogClientSingleton.javaJobsScheduler.javaPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes