-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Azure Table Storage #7095
Conversation
@geekwhocodes thanks for your contribution. Can you share the credentials over slack (DM) so that I can test this |
Hi @harshithmullapudi, pinged you on slack |
Hey @geekwhocodes can you also run |
airbyte-integrations/connectors/source-azure-table/source_azure_table/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/source_azure_table/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/source_azure_table/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/source_azure_table/reader.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/source_azure_table/reader.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/source_azure_table/spec.json
Outdated
Show resolved
Hide resolved
@harshithmullapudi Can you review requested changes? |
Hey @geekwhocodes can you move this PR out of Draft state if it ready ? Also rebase it with master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments otherwise LGTM. Once you are done with those I can publish this connector
airbyte-integrations/connectors/source-azure-table/integration_tests/invalid_config.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/integration_tests/abnormal_state.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/source_azure_table/source.py
Outdated
Show resolved
Hide resolved
@harshithmullapudi I think I messed up history, can you help me with rebase? |
Hey @geekwhocodes did you fix it already ? |
@harshithmullapudi I have made requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
airbyte-config/init/src/main/resources/seed/source_definitions.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-azure-table/source_azure_table/reader.py
Outdated
Show resolved
Hide resolved
@harshithmullapudi I have made requested changes. |
@harshithmullapudi did you get a chance to look at this? |
Hey @geekwhocodes thanks for the contribution. I have created a new branch out of this #7953 since there were some rebasing issues and thus closing this |
Thank you @harshithmullapudi :) |
What
How
This connector uses generic configured schema to support any table. Currently, it supports
full sync
only.Recommended reading order
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here