Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Azure Table Storage #7095

Closed
wants to merge 24 commits into from
Closed

🎉 New Source: Azure Table Storage #7095

wants to merge 24 commits into from

Conversation

geekwhocodes
Copy link
Contributor

@geekwhocodes geekwhocodes commented Oct 16, 2021

What

How

This connector uses generic configured schema to support any table. Currently, it supports full sync only.

Recommended reading order

  1. readme.md
  2. spec.json
  3. source.py
  4. reader.py
  5. constants.py

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 16, 2021
@geekwhocodes
Copy link
Contributor Author

geekwhocodes commented Oct 19, 2021

Adding proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output.

image

image

@harshithmullapudi
Copy link
Contributor

@geekwhocodes thanks for your contribution. Can you share the credentials over slack (DM) so that I can test this

@geekwhocodes
Copy link
Contributor Author

Hi @harshithmullapudi, pinged you on slack

@harshithmullapudi
Copy link
Contributor

Hey @geekwhocodes can you also run ./gradlew format

@geekwhocodes geekwhocodes marked this pull request as draft October 27, 2021 10:10
@geekwhocodes geekwhocodes marked this pull request as ready for review October 27, 2021 11:56
@geekwhocodes
Copy link
Contributor Author

@harshithmullapudi Can you review requested changes?

@harshithmullapudi
Copy link
Contributor

harshithmullapudi commented Oct 27, 2021

Hey @geekwhocodes can you move this PR out of Draft state if it ready ? Also rebase it with master

Copy link
Contributor

@harshithmullapudi harshithmullapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments otherwise LGTM. Once you are done with those I can publish this connector

@geekwhocodes
Copy link
Contributor Author

@harshithmullapudi I think I messed up history, can you help me with rebase?

@harshithmullapudi
Copy link
Contributor

Hey @geekwhocodes did you fix it already ?

@geekwhocodes
Copy link
Contributor Author

@harshithmullapudi I have made requested changes.

Copy link
Contributor

@harshithmullapudi harshithmullapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekwhocodes
Copy link
Contributor Author

@harshithmullapudi I have made requested changes.

@geekwhocodes
Copy link
Contributor Author

@harshithmullapudi did you get a chance to look at this?

@harshithmullapudi
Copy link
Contributor

Hey @geekwhocodes thanks for the contribution. I have created a new branch out of this #7953 since there were some rebasing issues and thus closing this

@geekwhocodes
Copy link
Contributor Author

Thank you @harshithmullapudi :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

7 participants