Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Publish new source: Azure table storage #7953

Merged
merged 27 commits into from
Nov 15, 2021

Conversation

harshithmullapudi
Copy link
Contributor

What

publishes #7095

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 14, 2021
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 14, 2021 18:37 Inactive
@harshithmullapudi harshithmullapudi force-pushed the harshith/test-pr-7095 branch 2 times, most recently from a7f9708 to e33d0c5 Compare November 14, 2021 18:40
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 14, 2021

/test connector=connectors/source-azure-table

🕑 connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459506455
❌ connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459506455
🐛 https://gradle.com/s/rdzojb6ukgais

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 14, 2021 18:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 18:44 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 14, 2021

/test connector=connectors/source-azure-table

🕑 connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459525482
❌ connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459525482
🐛

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 14, 2021 18:54 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 18:55 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 14, 2021

/test connector=connectors/source-azure-table

🕑 connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459561456
❌ connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459561456
🐛

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 14, 2021 19:13 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 19:15 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 14, 2021

/test connector=connectors/source-azure-table

🕑 connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459578656
✅ connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459578656
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-azure-table/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 Name                              Stmts   Miss  Cover
	   self._warn("No data was collected.", slug="no-data-collected")
	 -----------------------------------------------------
	 source_azure_table/__init__.py        2      2     0%
	 source_azure_table/constants.py       5      5     0%
	 source_azure_table/reader.py         61     61     0%
	 source_azure_table/source.py         43     43     0%
	 -----------------------------------------------------
	 TOTAL                               111    111     0%

@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 19:24 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 14, 2021

/publish connector=connectors/source-azure-table

🕑 connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459596400
✅ connectors/source-azure-table https://github.com/airbytehq/airbyte/actions/runs/1459596400

@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 19:35 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 14, 2021 19:44 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 15, 2021 06:18 Inactive
@harshithmullapudi harshithmullapudi changed the title Publish new source: Azure table storage 🚀 Publish new source: Azure table storage Nov 15, 2021
@harshithmullapudi harshithmullapudi merged commit 7c28f25 into master Nov 15, 2021
@harshithmullapudi harshithmullapudi deleted the harshith/test-pr-7095 branch November 15, 2021 06:36
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* add azure table storage source connector

* fix imports

* add connector docs

* Add azure table connector to the API/UI

* fix imports

* add azure table to builds.md

* Delete launch.json

* fix import paths

* remove azure prefic from spec params and cleanup

* gradlew format

* Merge branch 'patch-1' of https://github.com/geekwhocodes/airbyte into patch-1

* rename specs key names and cleanup

* rename specs key names and cleanup (#1)

* add comments

* fix source definitions

* added azure table credentials to ci

* chore: added axure-table to seed spec

Co-authored-by: geekwhocodes <ganeshraskar@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/azure-table connectors/sources-database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants