Source MongoDB fetch authorized collections only #9238

VitaliiMaltsev · 2021-12-31T14:51:39Z

What

Airbyte UI should return only those collections for which the user has privileges.

How

Used authorizedCollections:true flag in listCollections Mongo command

🚨 User Impact 🚨

There should not visible user impact. UI now will show only authorized collections

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

CLAassistant · 2021-12-31T14:51:44Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

VitaliiMaltsev · 2022-01-10T11:59:46Z

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1677239378
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1677239378
No Python unittests run

sashaNeshcheret · 2022-01-11T13:28:42Z

...rs/source-mongodb-v2/src/main/java/io.airbyte.integrations.source.mongodb/MongoDbSource.java

+        Document document = database.getDatabase().runCommand(new Document("listCollections", 1)
+                .append("authorizedCollections", true).append("nameOnly", true));
+
+        return document.toBsonDocument()
+                .get("cursor").asDocument()
+                .getArray("firstBatch")
+                        .stream()
+                .filter(bsonValue -> bsonValue.asDocument().getString("type").getValue().equals("collection"))
+                .map(bsonValue -> bsonValue.asDocument().getString("name").getValue())
+                .collect(Collectors.toSet());


Looks great)

tuliren

Can you format the code before merging? I think the indentation of the getAuthorizedCollections method is off.

tuliren · 2022-01-12T06:13:21Z

...rs/source-mongodb-v2/src/main/java/io.airbyte.integrations.source.mongodb/MongoDbSource.java

+                .get("cursor").asDocument()
+                .getArray("firstBatch")
+                        .stream()
+                .filter(bsonValue -> bsonValue.asDocument().getString("type").getValue().equals("collection"))


Nitpick .The listCollections command can take in a filter parameter to filter on any field in the returned document directly.

Reference: https://docs.mongodb.com/manual/reference/command/listCollections/#definition

I think if you add the filter parameter, you won't need to do the filter here:

Document document = database.getDatabase().runCommand(new Document("listCollections", 1) .append("authorizedCollections", true) .append("nameOnly", true)) .append("filter", "{ 'type': 'collection' }")

I am not 100% sure this is the correct syntax though.

Nitpick .The listCollections command can take in a filter parameter to filter on any field in the returned document directly.

Reference: https://docs.mongodb.com/manual/reference/command/listCollections/#definition

I think if you add the filter parameter, you won't need to do the filter here:

Document document = database.getDatabase().runCommand(new Document("listCollections", 1) .append("authorizedCollections", true) .append("nameOnly", true)) .append("filter", "{ 'type': 'collection' }")

I am not 100% sure this is the correct syntax though.

added filter into mongo shell command

VitaliiMaltsev · 2022-01-12T17:01:42Z

Can you format the code before merging? I think the indentation of the getAuthorizedCollections method is off.

formatted

…ed-collections # Conflicts: # airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeInternalStagingConsumerFactory.java

VitaliiMaltsev · 2022-01-13T13:08:11Z

/publish connector=connectors/source-mongodb-v2

…ed-collections

VitaliiMaltsev · 2022-01-13T13:26:58Z

/publish connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1692915725
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1692915725

vmaltsev added 16 commits December 15, 2021 10:45

fix for jdk 17

93d53ac

Merge branch 'master' of github.com:airbytehq/airbyte

ede8d38

Merge branch 'master' of github.com:airbytehq/airbyte

27be3fe

Merge branch 'master' of github.com:airbytehq/airbyte

ca75033

Merge branch 'master' of github.com:airbytehq/airbyte

72ab46f

Merge branch 'master' of github.com:airbytehq/airbyte

aec3384

Merge branch 'master' of github.com:airbytehq/airbyte

7efd5aa

Merge branch 'master' of github.com:airbytehq/airbyte

6a773f9

Merge branch 'master' of github.com:airbytehq/airbyte

fa18537

Merge branch 'master' of github.com:airbytehq/airbyte

b0ba37b

Merge branch 'master' of github.com:airbytehq/airbyte

fa31a0d

Merge branch 'master' of github.com:airbytehq/airbyte

67e0bd6

Merge branch 'master' of github.com:airbytehq/airbyte

ec0d1bd

Merge branch 'master' of github.com:airbytehq/airbyte

23598ec

Merge branch 'master' of github.com:airbytehq/airbyte

59d63e6

Source MongoDB show authorized collections

4d10720

github-actions bot added the area/connectors Connector related issues label Dec 31, 2021

Merge branch 'master' of github.com:airbytehq/airbyte

e2cb62c

octavia-squidington-iii temporarily deployed to more-secrets January 10, 2022 12:02 Inactive

add javadoc

f622758

VitaliiMaltsev temporarily deployed to more-secrets January 10, 2022 14:11 Inactive

fixed checkstyle

aae25d6

VitaliiMaltsev requested review from alexandr-shegeda and sashaNeshcheret January 10, 2022 14:20

VitaliiMaltsev temporarily deployed to more-secrets January 10, 2022 14:21 Inactive

vmaltsev added 3 commits January 10, 2022 19:00

Merge branch 'master' of github.com:airbytehq/airbyte

632583a

Merge branch 'master' of github.com:airbytehq/airbyte

2bc76ce

add CHANGELOG

0556234

VitaliiMaltsev temporarily deployed to more-secrets January 11, 2022 11:30 Inactive

fix checkstyle

a1c94e1

VitaliiMaltsev temporarily deployed to more-secrets January 11, 2022 11:32 Inactive

sashaNeshcheret approved these changes Jan 11, 2022

View reviewed changes

VitaliiMaltsev marked this pull request as ready for review January 11, 2022 15:26

VitaliiMaltsev requested a review from tuliren January 11, 2022 15:26

VitaliiMaltsev linked an issue Jan 11, 2022 that may be closed by this pull request

Source Mongo DB: Failed to fetch schema if user doesn't have permissions for all collections in db #8752

Closed

tuliren approved these changes Jan 12, 2022

View reviewed changes

refactoring

a51ec08

VitaliiMaltsev temporarily deployed to more-secrets January 12, 2022 16:11 Inactive

bump version anf fix checkstyle

45dfc2d

VitaliiMaltsev temporarily deployed to more-secrets January 12, 2022 17:01 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 12, 2022 17:03 Inactive

vmaltsev added 2 commits January 12, 2022 19:20

Merge branch 'master' of github.com:airbytehq/airbyte

9baf2e1

Merge branch 'master' into vmaltsev/8752-source-mongodb-show-authoriz…

9942d14

…ed-collections # Conflicts: # airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeInternalStagingConsumerFactory.java

VitaliiMaltsev temporarily deployed to more-secrets January 12, 2022 17:26 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 13, 2022 08:11 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 13, 2022 13:10 Inactive

vmaltsev added 2 commits January 13, 2022 15:12

Merge branch 'master' of github.com:airbytehq/airbyte

ed4f1ba

Merge branch 'master' into vmaltsev/8752-source-mongodb-show-authoriz…

6d073b7

…ed-collections

VitaliiMaltsev temporarily deployed to more-secrets January 13, 2022 13:28 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 13, 2022 13:29 Inactive

VitaliiMaltsev merged commit 2b0d0bd into master Jan 13, 2022

VitaliiMaltsev deleted the vmaltsev/8752-source-mongodb-show-authorized-collections branch January 13, 2022 13:41

octavia-squidington-iii mentioned this pull request Jan 13, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9483

Closed

alafanechere mentioned this pull request Jan 13, 2022

Source MongoDB: only discover collections on which user has reading permissions #9482

Closed

octavia-squidington-iii mentioned this pull request Jan 20, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source MongoDB fetch authorized collections only #9238

Source MongoDB fetch authorized collections only #9238

VitaliiMaltsev commented Dec 31, 2021 •

edited

Loading

CLAassistant commented Dec 31, 2021

VitaliiMaltsev commented Jan 10, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret Jan 11, 2022

tuliren left a comment

tuliren Jan 12, 2022

VitaliiMaltsev Jan 12, 2022

VitaliiMaltsev commented Jan 12, 2022

VitaliiMaltsev commented Jan 13, 2022

VitaliiMaltsev commented Jan 13, 2022 •

edited by github-actions bot

Loading

Source MongoDB fetch authorized collections only #9238

Source MongoDB fetch authorized collections only #9238

Conversation

VitaliiMaltsev commented Dec 31, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Dec 31, 2021

VitaliiMaltsev commented Jan 10, 2022 • edited by github-actions bot Loading

sashaNeshcheret Jan 11, 2022

Choose a reason for hiding this comment

tuliren left a comment

Choose a reason for hiding this comment

tuliren Jan 12, 2022

Choose a reason for hiding this comment

VitaliiMaltsev Jan 12, 2022

Choose a reason for hiding this comment

VitaliiMaltsev commented Jan 12, 2022

VitaliiMaltsev commented Jan 13, 2022

VitaliiMaltsev commented Jan 13, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Dec 31, 2021 •

edited

Loading

VitaliiMaltsev commented Jan 10, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Jan 13, 2022 •

edited by github-actions bot

Loading