Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination BigQuery: update description for some fields #9573

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

yurii-bidiuk
Copy link
Contributor

@yurii-bidiuk yurii-bidiuk commented Jan 18, 2022

What

Fixes #7846

How

Updated description for Transformation Query Run Type and Google BigQuery client chunk size

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

There is no user impact. Only description is changed

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jan 18, 2022
@yurii-bidiuk yurii-bidiuk force-pushed the bidiuk/7846-simplify-bq-setup branch from 81e7f27 to ce12128 Compare January 18, 2022 12:11
@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets January 18, 2022 12:13 Inactive
@yurii-bidiuk yurii-bidiuk changed the title Destination BigQuery: update fdescription for some fields Destination BigQuery: update description for some fields Jan 18, 2022
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merging without airbyte review

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 18, 2022
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Jan 18, 2022

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1713689678
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1713689678
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     155      8    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520    333    36%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     34    77%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    525    58%

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Jan 18, 2022

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1713690179
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1713690179
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     155      8    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520    333    36%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     34    77%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    525    58%

@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets January 18, 2022 16:10 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 16:11 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 16:11 Inactive
@yurii-bidiuk yurii-bidiuk force-pushed the bidiuk/7846-simplify-bq-setup branch from 68b68d6 to 723c4c8 Compare January 18, 2022 18:05
@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets January 18, 2022 18:07 Inactive
@yurii-bidiuk yurii-bidiuk force-pushed the bidiuk/7846-simplify-bq-setup branch from 723c4c8 to c0355fa Compare January 18, 2022 18:37
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Jan 18, 2022

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1714308017
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1714308017

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Jan 18, 2022

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1714309133
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1714309133

@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets January 18, 2022 18:39 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 18:41 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 18:41 Inactive
@yurii-bidiuk yurii-bidiuk force-pushed the bidiuk/7846-simplify-bq-setup branch from c0355fa to b8958a8 Compare January 18, 2022 18:48
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Jan 18, 2022

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1714346562
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1714346562

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Jan 18, 2022

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1714347595
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1714347595

@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets January 18, 2022 18:50 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 18:51 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 18:52 Inactive
@yurii-bidiuk yurii-bidiuk marked this pull request as ready for review January 18, 2022 19:58
@yurii-bidiuk yurii-bidiuk merged commit 0187efd into master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify BigQuery Destination Setup
3 participants