runner: fix handling of forkserver benchmark suite import-time errors #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark runner should tolerate forkserver crashes and import-time errors, and only skip benchmarks concerned rather than failing with an error.
This ensures the pid remains valid, so that the calls to killpg_safe in ForkServer.close work.
pv
force-pushed
the
fix-bench-import-failure
branch
from
ce01567
to
7645516
Compare
pv
added
the
backport-candidate
pv
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark runner should tolerate forkserver crashes and import-time
errors, and only skip benchmarks concerned rather than failing with an
error.