Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner: fix handling of forkserver benchmark suite import-time errors #742

Merged
merged 3 commits into from
Sep 20, 2018

Commits on Sep 19, 2018

  1. runner: fix handling of forkserver benchmark suite import-time errors

    Benchmark runner should tolerate forkserver crashes and import-time
    errors, and only skip benchmarks concerned rather than failing with an
    error.
    pv committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    43bf53e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca63acc View commit details
    Browse the repository at this point in the history
  3. forkserver: wait for child process in main thread

    This ensures the pid remains valid, so that the calls to killpg_safe in
    ForkServer.close work.
    pv committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    7645516 View commit details
    Browse the repository at this point in the history