Ratelimiter does not keep process running until all requests are finished

[bsingr]

Problem example

Here it shows a Promise.all does not longer keep the process alive, it terminates... I guess this ratelimiter was implemented with daemonized scripts in mind?

const axios = require('axios')
const rl = require('axios-rate-limit');

// sets max 2 requests per 1 second, other will be delayed
const http = rl(axios.create(), { maxRequests: 2, perMilliseconds: 1000 });

Promise.all([
  http.get('http://httpbin.org/get').then(x => {console.log(1); return x}),
  http.get('http://httpbin.org/get').then(x => {console.log(2); return x}),
  http.get('http://httpbin.org/get').then(x => {console.log(3); return x}),
]).then(x => {
  console.log('after')
})

Problem workaround

If you count yourself how many requests you scheduled and if they are all finished or just add a global timeout to keep the process alive it works:

const axios = require('axios')
const rl = require('axios-rate-limit');

// sets max 2 requests per 1 second, other will be delayed
const http = rl(axios.create(), { maxRequests: 2, perMilliseconds: 1000 });

Promise.all([
  http.get('http://httpbin.org/get').then(x => {console.log(1); return x}),
  http.get('http://httpbin.org/get').then(x => {console.log(2); return x}),
  http.get('http://httpbin.org/get').then(x => {console.log(3); return x}),
]).then(x => {
  console.log('after')
})

setTimeout(function() {
  console.log('kept alive for 5s')
}, 5000)

[aishek]

No, the bug was introduced in #13. I just released version 1.1.3 with the fix. Could you confirm everything is working as expected now?

[bsingr]

That works for me, thanks alot!

[aishek]

If someone knows how to test ref and unref calls or it's sideeffects in Jest, please let me know. The PR is missing tests.