Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not keep process alive waiting for request timeout #13

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Do not keep process alive waiting for request timeout #13

merged 3 commits into from
Aug 28, 2019

Conversation

terotil
Copy link
Contributor

@terotil terotil commented Aug 27, 2019

When using rate limiter with node CLI script, it unnecessarily keeps node process alive waiting for request counter timeout. Using unref() is an uncompromising way of letting the process exit if all else has been executed except the request counter timeout.

BTW Linter doesn't pass with clean clone from current master (with or without my change). It complains

 Error: /home/tero/src/axios-rate-limit/node_modules/@logux/eslint-config/base.js:
	Configuration for rule "import-helpers/order-imports" is invalid:
	Value {"groups":[["absolute","module"],["parent","sibling","index"]],"newlinesBetween":"always"} should NOT have additional properties.

I didn't try to fix that.

@terotil
Copy link
Contributor Author

terotil commented Aug 27, 2019

Apparently the linter failure was caused by me using npm instead of yarn and therefore dependency locking was not obeyed. With yarn it is working.

@aishek aishek merged commit f08fa61 into aishek:master Aug 28, 2019
@aishek
Copy link
Owner

aishek commented Aug 28, 2019

Thanks for the fix!

I just published version 1.1.2.

@aishek
Copy link
Owner

aishek commented Sep 16, 2019

@terotil Could you test version 1.1.3 and reply how it works please? I've recently updated ref-related behaviour because of #16

@terotil
Copy link
Contributor Author

terotil commented Feb 3, 2020

A little late to the game... but working nicely still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants