Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ref/unref behaviour #17

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Fix ref/unref behaviour #17

merged 1 commit into from
Sep 15, 2019

Conversation

aishek
Copy link
Owner

@aishek aishek commented Sep 15, 2019

Pull request for issue #16

@aishek aishek added the bug Something isn't working label Sep 15, 2019
@aishek aishek self-assigned this Sep 15, 2019
@aishek aishek merged commit da7e7ad into master Sep 15, 2019
@aishek aishek deleted the fix-ref-unref branch September 15, 2019 16:40
@aishek
Copy link
Owner Author

aishek commented Sep 16, 2019

If someone knows how to test ref and unref calls or it's sideeffects in Jest, please let me know. The PR is missing tests.

@aishek aishek added the help wanted Extra attention is needed label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aishek aishek

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aishek