Merge pull request #5418 from akoreman/loading_fix

fix: don't show loading state when empty completer array is provided
ajaxorg · Dec 11, 2023 · ef29ada · ef29ada
2 parents c6475c0 + 7e08bf5
commit ef29ada
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/autocomplete.js b/src/autocomplete.js
@@ -112,7 +112,7 @@ class Autocomplete {
 
         this.$firstOpenTimer = lang.delayedCall(/**@this{Autocomplete}*/function() {
             var initialPosition = this.completionProvider && this.completionProvider.initialPosition;
-            if (this.autoShown || (this.popup && this.popup.isOpen) || !initialPosition) return;
+            if (this.autoShown || (this.popup && this.popup.isOpen) || !initialPosition || this.editor.completers.length === 0) return;
 
             this.completions = new FilteredList(Autocomplete.completionsForLoading);
             this.openPopup(this.editor, initialPosition.prefix, false);

diff --git a/src/autocomplete_test.js b/src/autocomplete_test.js
@@ -1328,6 +1328,19 @@ module.exports = {
 
             done();
         }, 100);
+    },
+    "test: should not show loading state when empty completer array is provided": function(done) {
+        var editor = initEditor("");
+        editor.completers = [];
+        var completer = Autocomplete.for(editor);
+        completer.showLoadingState = true;
+
+        user.type("Ctrl-Space");
+
+        // Tooltip should not be open
+        assert.ok(!(completer.popup && completer.popup.isOpen));
+
+        done();
     }
 };