Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show loading state when empty completer array is provided #5418

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Dec 8, 2023

Issue #, if available: NA

Description of changes: Currently, when providing an empty completer array, we show the popup with the completion loading state indefinitely:

Screen.Recording.2023-12-08.at.16.07.43.mov

This adds a check for the completer length in the showing of the loading popup.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aac600d) 87.59% compared to head (7e08bf5) 87.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5418   +/-   ##
=======================================
  Coverage   87.59%   87.60%           
=======================================
  Files         583      583           
  Lines       46389    46397    +8     
  Branches     7018     7019    +1     
=======================================
+ Hits        40636    40644    +8     
  Misses       5753     5753           
Flag Coverage Δ
unittests 87.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit ef29ada into ajaxorg:master Dec 11, 2023
3 checks passed
@akoreman akoreman deleted the loading_fix branch December 11, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants