Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't show loading state when empty completer array is provided #5418

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: don't show loading state when empty completer array is provided #5418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a8a929
fix: don't show loading state when empty completer array is provided
akoreman Dec 8, 2023
7e08bf5
Merge branch 'ajaxorg:master' into loading_fix
akoreman Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class Autocomplete {

this.$firstOpenTimer = lang.delayedCall(/**@this{Autocomplete}*/function() {
var initialPosition = this.completionProvider && this.completionProvider.initialPosition;
if (this.autoShown || (this.popup && this.popup.isOpen) || !initialPosition) return;
if (this.autoShown || (this.popup && this.popup.isOpen) || !initialPosition || this.editor.completers.length === 0) return;

this.completions = new FilteredList(Autocomplete.completionsForLoading);
this.openPopup(this.editor, initialPosition.prefix, false);
Expand Down
13 changes: 13 additions & 0 deletions src/autocomplete_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict";

var sendKey = require("./test/user").type;
var {buildDom} = require("./lib/dom");

Check warning on line 8 in src/autocomplete_test.js

View workflow job for this annotation

GitHub Actions / build (16.x) 

'buildDom' is assigned a value but never used
var ace = require("./ace");
var assert = require("./test/assertions");
var user = require("./test/user");
Expand Down Expand Up @@ -1328,6 +1328,19 @@

done();
}, 100);
},
"test: should not show loading state when empty completer array is provided": function(done) {
var editor = initEditor("");
editor.completers = [];
var completer = Autocomplete.for(editor);
completer.showLoadingState = true;

user.type("Ctrl-Space");

// Tooltip should not be open
assert.ok(!(completer.popup && completer.popup.isOpen));

done();
}
};

Expand Down
Loading