-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take underflows when full pool debt repaid #551
Commits on Jan 12, 2023
-
Create standardized PR templates for contracts (#539)
This PR creates three github PR templates that should be followed: * `logic_src_changes.md` * `cosmetic_src_changes.md` * `testing_or_misc_nonsrc_changes.md` To learn more about how GH templates work -> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository Co-authored-by: Ian Harvey <iharvey@comcast.net>
Configuration menu - View commit details
-
Copy full SHA for c718d1f - Browse repository at this point
Copy the full SHA c718d1fView commit details
Commits on Jan 16, 2023
-
reworked the RNG to use a deterministic seed (#523)
* reworked the RNG to use a deterministic seed * reordered params such that they are in the same order as "bound" is called * Nonfuzzy fill (#529) * work in progress * reproduced fenwick tree failures at last index * proposed changes in light that max index is special case for prefix suim (#533) * proposed changes in light that max index is special case for prefix suim * removed comment Co-authored-by: mwc <matt@ajna.finance> Co-authored-by: Ed Noepel <ed@lpl.io> * removed two temp tests * ported Matt's changes to the fuzzed implementation Co-authored-by: mattcushman <36414299+mattcushman@users.noreply.github.com> Co-authored-by: mwc <matt@ajna.finance> Co-authored-by: Ed Noepel <ed@lpl.io> Co-authored-by: mattcushman <36414299+mattcushman@users.noreply.github.com> Co-authored-by: mwc <matt@ajna.finance> Co-authored-by: Ed Noepel <ed@lpl.io>
Configuration menu - View commit details
-
Copy full SHA for 12ae2a5 - Browse repository at this point
Copy the full SHA 12ae2a5View commit details -
* Diagrams * Add components * Updates * Center components * add pool architectire diagrams (#536) Co-authored-by: prateek105 <prateek@ajna.finance> Co-authored-by: Prateek Gupta <prateek105@users.noreply.github.com> Co-authored-by: prateek105 <prateek@ajna.finance>
Configuration menu - View commit details
-
Copy full SHA for 70f2c50 - Browse repository at this point
Copy the full SHA 70f2c50View commit details -
Test Coverage and Tests Style improvements (#541)
* - Ajna balance less than rewards tests * NFT take tests * Loan heap test coverage * PoolCommons 100% test coverage - no interest earned when htp > max price * Test coverage move dusty amount * Changes after review: - comments - common style on touched tests * Common style across all unit tests
Configuration menu - View commit details
-
Copy full SHA for b22dd48 - Browse repository at this point
Copy the full SHA b22dd48View commit details
Commits on Jan 17, 2023
-
PositionManager and RewardsManager deployment (#547)
* replaced bash script with forge script, update for PositionManager and RewardsManager * intentionally broke example addresses so no one tries to use them for anything
Configuration menu - View commit details
-
Copy full SHA for 4892b26 - Browse repository at this point
Copy the full SHA 4892b26View commit details -
* testing set-output for size-check * update to cachev3 * make it look like an env var * use it like an env var * revert to old usage syntax * deleted redundant forge test, since code coverage already runs the tests
Configuration menu - View commit details
-
Copy full SHA for 24e66da - Browse repository at this point
Copy the full SHA 24e66daView commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c645a05 - Browse repository at this point
Copy the full SHA c645a05View commit details -
Fix for Borrower won't be able to pull his entitled NFT collateral fr…
…om pool after take / bucketTake
Configuration menu - View commit details
-
Copy full SHA for 4b4c2d3 - Browse repository at this point
Copy the full SHA 4b4c2d3View commit details -
* merged all of the templates into one so the text will auto fill when a PR is created. * was running into this issue documented here with auto fill -> https://stackoverflow.com/questions/52139192/github-pull-requests-template-not-showing
Configuration menu - View commit details
-
Copy full SHA for f5ace44 - Browse repository at this point
Copy the full SHA f5ace44View commit details -
Configuration menu - View commit details
-
Copy full SHA for acc994a - Browse repository at this point
Copy the full SHA acc994aView commit details
Commits on Jan 21, 2023
-
Changes after review: calculate first t0 kick penalty based on t0 kic…
…ked debt, then kick penalty for current inflator
Configuration menu - View commit details
-
Copy full SHA for 4a3441c - Browse repository at this point
Copy the full SHA 4a3441cView commit details -
Changes after review: when borrowing, calculate first t0 amount to bo…
…rrow, then apply fee rate
Configuration menu - View commit details
-
Copy full SHA for f696de6 - Browse repository at this point
Copy the full SHA f696de6View commit details
Commits on Jan 31, 2023
-
Revert "Fix for Borrower won't be able to pull his entitled NFT colla…
…teral from pool after take / bucketTake" This reverts commit 4b4c2d3.
Configuration menu - View commit details
-
Copy full SHA for 0fa6c47 - Browse repository at this point
Copy the full SHA 0fa6c47View commit details -
Merge branch 'fix-review', remote-tracking branch 'origin' into take-…
…repay-all-overflow
Configuration menu - View commit details
-
Copy full SHA for 0369416 - Browse repository at this point
Copy the full SHA 0369416View commit details