Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take underflows when full pool debt repaid #551

Merged
merged 14 commits into from
Jan 31, 2023

Commits on Jan 12, 2023

  1. Create standardized PR templates for contracts (#539)

    This PR creates three github PR templates that should be followed:
    * `logic_src_changes.md`
    * `cosmetic_src_changes.md`
    * `testing_or_misc_nonsrc_changes.md`
    
    To learn more about how GH templates work -> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
    
    Co-authored-by: Ian Harvey <iharvey@comcast.net>
    ith-harvey and Ian Harvey authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c718d1f View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. reworked the RNG to use a deterministic seed (#523)

    * reworked the RNG to use a deterministic seed
    
    * reordered params such that they are in the same order as "bound" is called
    
    * Nonfuzzy fill (#529)
    
    * work in progress
    
    * reproduced fenwick tree failures at last index
    
    * proposed changes in light that max index is special case for prefix suim (#533)
    
    * proposed changes in light that max index is special case for prefix suim
    
    * removed comment
    
    Co-authored-by: mwc <matt@ajna.finance>
    Co-authored-by: Ed Noepel <ed@lpl.io>
    
    * removed two temp tests
    
    * ported Matt's changes to the fuzzed implementation
    
    Co-authored-by: mattcushman <36414299+mattcushman@users.noreply.github.com>
    Co-authored-by: mwc <matt@ajna.finance>
    Co-authored-by: Ed Noepel <ed@lpl.io>
    
    Co-authored-by: mattcushman <36414299+mattcushman@users.noreply.github.com>
    Co-authored-by: mwc <matt@ajna.finance>
    Co-authored-by: Ed Noepel <ed@lpl.io>
    4 people authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    12ae2a5 View commit details
    Browse the repository at this point in the history
  2. Docs (#535)

    * Diagrams
    
    * Add components
    
    * Updates
    
    * Center components
    
    * add pool architectire diagrams (#536)
    
    Co-authored-by: prateek105 <prateek@ajna.finance>
    
    Co-authored-by: Prateek Gupta <prateek105@users.noreply.github.com>
    Co-authored-by: prateek105 <prateek@ajna.finance>
    3 people authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    70f2c50 View commit details
    Browse the repository at this point in the history
  3. Test Coverage and Tests Style improvements (#541)

    * - Ajna balance less than rewards tests
    
    * NFT take tests
    
    * Loan heap test coverage
    
    * PoolCommons 100% test coverage - no interest earned when htp > max price
    
    * Test coverage move dusty amount
    
    * Changes after review:
    - comments
    - common style on touched tests
    
    * Common style across all unit tests
    grandizzy authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    b22dd48 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. PositionManager and RewardsManager deployment (#547)

    * replaced bash script with forge script, update for PositionManager and RewardsManager
    
    * intentionally broke example addresses so no one tries to use them for anything
    EdNoepel authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    4892b26 View commit details
    Browse the repository at this point in the history
  2. CI updates (#549)

    * testing set-output for size-check
    
    * update to cachev3
    
    * make it look like an env var
    
    * use it like an env var
    
    * revert to old usage syntax
    
    * deleted redundant forge test, since code coverage already runs the tests
    EdNoepel authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    24e66da View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Take underflow bug fix

    grandizzy committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c645a05 View commit details
    Browse the repository at this point in the history
  2. Fix for Borrower won't be able to pull his entitled NFT collateral fr…

    …om pool after take / bucketTake
    grandizzy committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    4b4c2d3 View commit details
    Browse the repository at this point in the history
  3. Single template (#546)

    * merged all of the templates into one so the text will auto fill when a PR is created.
    * was running into this issue documented here with auto fill -> https://stackoverflow.com/questions/52139192/github-pull-requests-template-not-showing
    ith-harvey authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f5ace44 View commit details
    Browse the repository at this point in the history
  4. Fix if / else style

    grandizzy committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    acc994a View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Changes after review: calculate first t0 kick penalty based on t0 kic…

    …ked debt, then kick penalty for current inflator
    grandizzy committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    4a3441c View commit details
    Browse the repository at this point in the history
  2. Changes after review: when borrowing, calculate first t0 amount to bo…

    …rrow, then apply fee rate
    grandizzy committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    f696de6 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Revert "Fix for Borrower won't be able to pull his entitled NFT colla…

    …teral from pool after take / bucketTake"
    
    This reverts commit 4b4c2d3.
    grandizzy committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0fa6c47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0369416 View commit details
    Browse the repository at this point in the history