generated from refcell/femplate
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take underflows when full pool debt repaid #551
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c718d1f
Create standardized PR templates for contracts (#539)
ith-harvey 12ae2a5
reworked the RNG to use a deterministic seed (#523)
EdNoepel 70f2c50
Docs (#535)
grandizzy b22dd48
Test Coverage and Tests Style improvements (#541)
grandizzy 4892b26
PositionManager and RewardsManager deployment (#547)
EdNoepel 24e66da
CI updates (#549)
EdNoepel c645a05
Take underflow bug fix
grandizzy 4b4c2d3
Fix for Borrower won't be able to pull his entitled NFT collateral fr…
grandizzy f5ace44
Single template (#546)
ith-harvey acc994a
Fix if / else style
grandizzy 4a3441c
Changes after review: calculate first t0 kick penalty based on t0 kic…
grandizzy f696de6
Changes after review: when borrowing, calculate first t0 amount to bo…
grandizzy 0fa6c47
Revert "Fix for Borrower won't be able to pull his entitled NFT colla…
grandizzy 0369416
Merge branch 'fix-review', remote-tracking branch 'origin' into take-…
grandizzy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
|
||
<!--- | ||
No need to add special tag | ||
src/ & non src/ changes you need the following (that apply): | ||
--> | ||
# Description of change | ||
## High level | ||
* <DESCRIP_OF_CHANGE> | ||
* <DESCRIP_OF_SUBCHANGE> | ||
|
||
<!--- | ||
Add the `Status: Needs Auditor Approval` tags | ||
CHANGES IN /SRC DIR: | ||
- renaming (not retyping or resizing) of variables & methods | ||
- reordering and moving of functions in files | ||
- lite moving of functions accross files | ||
- comments | ||
|
||
src/ changes you need the following (that apply): | ||
--> | ||
|
||
# Description of bug or vulnerability and solution | ||
* <PARAGRAPH_EXP_OF_VULN_BUG> | ||
* <PARAGRAPH_EXP_OF_HOW_CHANGE_SOLVES_VULN_OR_BUG> | ||
|
||
# Contract size | ||
## Pre Change | ||
<PASTE_OUTPUT_HERE> | ||
## Post Change | ||
<PASTE_OUTPUT_HERE> | ||
|
||
# Gas usage | ||
## Pre Change | ||
<PASTE_OUTPUT_HERE> | ||
## Post Change | ||
<PASTE_OUTPUT_HERE> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a fine way to do it, but curious did you see a problem with the previous way, of adding the t0kickpenalty to the global debt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, just wanted to be consistent