Sherlock 131.md:

.github/pull_request_template.md

@@ -0,0 +1,37 @@
+
+<!---
+No need to add special tag
+src/ & non src/ changes you need the following (that apply):
+-->
+# Description of change
+## High level
+* <DESCRIP_OF_CHANGE>
+  * <DESCRIP_OF_SUBCHANGE>
+
+<!---
+Add the `Status: Needs Auditor Approval` tags
+CHANGES IN /SRC DIR:
+- renaming (not retyping or resizing) of variables & methods
+- reordering and moving of functions in files
+- lite moving of functions accross files
+- comments
+
+src/ changes you need the following (that apply):
+-->
+
+# Description of bug or vulnerability and solution
+* <PARAGRAPH_EXP_OF_VULN_BUG>
+* <PARAGRAPH_EXP_OF_HOW_CHANGE_SOLVES_VULN_OR_BUG>
+
+# Contract size
+## Pre Change
+<PASTE_OUTPUT_HERE>
+## Post Change
+<PASTE_OUTPUT_HERE>
+
+# Gas usage
+## Pre Change
+<PASTE_OUTPUT_HERE>
+## Post Change
+<PASTE_OUTPUT_HERE>
+

src/PositionManager.sol

@@ -180,7 +180,7 @@ contract PositionManager is ERC721, PermitERC721, IPositionManager, Multicall, R
      */
     function mint(
         MintParams calldata params_
-    ) external override returns (uint256 tokenId_) {
+    ) external override nonReentrant returns (uint256 tokenId_) {
         tokenId_ = _nextId++;
 
         // revert if the address is not a valid Ajna pool

src/interfaces/position/IPositionManagerOwnerActions.sol

@@ -29,7 +29,8 @@ interface IPositionManagerOwnerActions {
     ) external;
 
     /**
-     *  @notice Called by owners to add quote tokens and receive a representative NFT.
+     *  @notice Called by owners to mint and receive an Ajna Position NFT.
+     *  @dev    PositionNFTs can only be minited with an association to pools that have been deployed by the Ajna ERC20PoolFactory or ERC721PoolFactory.
      *  @param  params  Calldata struct supplying inputs required to mint a positions NFT.
      *  @return tokenId The tokenId of the newly minted NFT.
      */
@@ -104,4 +105,4 @@ interface IPositionManagerOwnerActions {
         address   pool;    // The pool address associated with positions NFT
         uint256[] indexes; // The array of bucket indexes to reedem positions for
     }
-}
+}