Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block addqt above auction price #997

Merged
merged 17 commits into from
Dec 4, 2023
Merged

Block addqt above auction price #997

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
dcbb18e
initial commit
Dec 1, 2023
ba38d6c
tweaks to Matt's PR to block adding quote token above auction price (…
EdNoepel Dec 1, 2023
61eb0f8
fixed testDepositTakeAndSettleByRegularTakeSubsetPool
Dec 2, 2023
f78d812
fixed tests in ERC20PoolLiquidationsArbTake.t.sol
Dec 2, 2023
877f9ce
fixed tests in ERC20PoolLiquidationsDepositTake.sol
Dec 2, 2023
723d4bb
fixed two more
Dec 2, 2023
70f3b07
updated testDepositTakeAndSettleSubsetPool
EdNoepel Dec 3, 2023
54a8a1a
updated testKickAndSettleSubsetPoolFractionalCollateral
EdNoepel Dec 3, 2023
bfebe3c
updated testSettleWithDepositFuzzy
EdNoepel Dec 3, 2023
cd12a56
Fixed final tests
Dec 3, 2023
8048000
Merge branch 'merge-rc9' into block-addqt-above-auction-price
EdNoepel Dec 3, 2023
2b3b930
add "AddAboveAuctionPrice" as expected pool error
EdNoepel Dec 3, 2023
d632f2c
implemented invariant A9: reference prices in liquidation queue shall…
EdNoepel Dec 3, 2023
a62d5c5
Update assertAuction to use ThresholdPrice from auctionInfo (#1003)
MikeHathaway Dec 3, 2023
0f2cf48
Contract size mitigation (#1004)
EdNoepel Dec 4, 2023
c5110e5
added unit test showing adding qt above auction price reverts
Dec 4, 2023
d5d0ca7
updated nit spellings
Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/interfaces/pool/commons/IPoolErrors.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ interface IPoolErrors {
/*** Common Pool Errors ***/
/**************************/

/**
* @notice Adding liquidity above current auction price.
*/
error AddAboveAuctionPrice();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing trailing blankline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved -> d5d0ca7

/**
* @notice `LP` allowance is already set by the owner.
*/
Expand Down
Loading
Loading