Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot deserialize types when simplified qualified name is not resolvable by .NET framework #117

Closed
alexvaut opened this issue Aug 27, 2019 · 1 comment · Fixed by #208
Closed

Comments

@alexvaut
Copy link
Contributor

To reproduce, add this test in Hyperion.Tests:

    [Fact]
    public void CanSerializeColor()
    {
	var expected = Color.Aquamarine;
        Serialize(expected);
        Reset();
        var actual = Deserialize<Color>();
        Assert.Equal(expected, actual);
    }

This test in all the .NET core versions will pass but not the one in .NET framework.
The reason is that "System.Drawing.Color, System.Drawing" is not a fully qualified type name in .NET framework.

@Aaronontheweb
Copy link
Member

@alexvaut is this still the case after #116 - could you please send a PR with this test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants