Fix cross framework incompatibility for System.Drawing.Color #208
Conversation
src/Hyperion/Extensions/TypeEx.cs
Outdated
| @@ -123,6 +123,11 @@ private static Type GetTypeFromManifestName(Stream stream, DeserializerSession s | |||
| { | |||
| shortName = shortName.Replace("System.Private.CoreLib,%core%", "mscorlib,%core%"); | |||
| } | |||
|
|
|||
| if (shortName.Contains("System.Drawing.Primitives")) | |||
There was a problem hiding this comment.
Ah, this is another case of where a single namespace was changed between .NET framework and .NET core?
There was a problem hiding this comment.
They decided that structs are primitives and moved all structs inside System.Drawing into System.Drawing.Primitives
| _serializer = new Serializer(new SerializerOptions( | ||
| packageNameOverrides: new List<CrossPlatformPackageNameOverride> | ||
| { | ||
| new CrossPlatformPackageNameOverride("System.Drawing.Primitives", ".Primitives", "") |
There was a problem hiding this comment.
So how does this work exactly @Arkatufus ? What's the formula for substituting names in one package for another?
There was a problem hiding this comment.
The first string is the "fingerprint", the unique string that indicates the wrong package name. It is matched using string.Contain.
The second string is the string pattern that needs to be replaced.
The third is the string to replace it with.
In this example, "if the package name contains the string System.Drawing.Primitives, replace .Primitives with an empty string.
There was a problem hiding this comment.
How could we make that more intuitive?
There was a problem hiding this comment.
I don't know, any ideas?
There was a problem hiding this comment.
Think passing in a Func<string,string> predicate would make more sense? Leave it up to the user how to transform the name?
There was a problem hiding this comment.
Sounds good, I'll make the changes
There was a problem hiding this comment.
oh... I just remembered... we can't do that, it has to be a set of strings, because this will have to be configurable from hocon
There was a problem hiding this comment.
We can always pass in a Setup for this for Hyperion just like we did for Newtonsoft.Json .
There was a problem hiding this comment.
And you can add a layer that translates HOCON into these delegates too but for this level of customization passing in an array of typed functions is probably better.
| { | ||
| shortName = shortName.Replace("mscorlib,%core%", "System.Private.CoreLib,%core%"); | ||
| shortName = adapter(shortName); | ||
| if (!ReferenceEquals(oldName, shortName)) |
There was a problem hiding this comment.
Optimization, bail out as soon as there is a match, we will only allow one transformation.
| _serializer = new Serializer(new SerializerOptions( | ||
| packageNameOverrides: new List<Func<string, string>> | ||
| { | ||
| str => str.Contains("System.Drawing.Primitives") ? str.Replace(".Primitives", "") : str |
| return new List<Func<string, string>> | ||
| { | ||
| #if NET45 | ||
| str => str.Contains("System.Private.CoreLib,%core%") |
Closes #117
Closes #206