-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross framework incompatibility for System.Drawing.Color #208
Merged
Aaronontheweb
merged 5 commits into
akkadotnet:dev
from
Arkatufus:Fix_XFramework_System.Drawing.Color
Apr 13, 2021
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4f9a643
Fix cross framework problem with System.Drawing
Arkatufus 228aea6
Merge PR #206 test case
Arkatufus 92bbaa8
Generalize type package name transformation for cross framework compa…
Arkatufus 821133e
Define compiler directives that are missing in CI/CD
Arkatufus 91a4d8f
Change class based configuration to lambda function
Arkatufus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+450 Bytes
(160%)
src/Hyperion.Tests/testfiles/mixed_test_file_.netcoreappversionv2.0.tf
Binary file not shown.
Binary file modified
BIN
+450 Bytes
(160%)
src/Hyperion.Tests/testfiles/mixed_test_file_.netcoreappversionv2.1.tf
Binary file not shown.
Binary file modified
BIN
+450 Bytes
(160%)
src/Hyperion.Tests/testfiles/mixed_test_file_.netcoreappversionv2.2.tf
Binary file not shown.
Binary file modified
BIN
+450 Bytes
(160%)
src/Hyperion.Tests/testfiles/mixed_test_file_.netcoreappversionv3.0.tf
Binary file not shown.
Binary file modified
BIN
+450 Bytes
(160%)
src/Hyperion.Tests/testfiles/mixed_test_file_.netcoreappversionv3.1.tf
Binary file not shown.
Binary file modified
BIN
+450 Bytes
(160%)
src/Hyperion.Tests/testfiles/mixed_test_file_.netcoreappversionv5.0.tf
Binary file not shown.
Binary file modified
BIN
+373 Bytes
(150%)
src/Hyperion.Tests/testfiles/mixed_test_file_.netframeworkversionv4.6.1.tf
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is another case of where a single namespace was changed between .NET framework and .NET core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They decided that structs are primitives and moved all structs inside
System.Drawing
intoSystem.Drawing.Primitives