Fix SerializeStructBenchmark, Serializer not initialized #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jan 11, 2022
| } | ||
| else | ||
| { | ||
| benchmark.Run(args); |
There was a problem hiding this comment.
Slight changes so we can pass arguments to BenchmarkDotNet from command line.
RunAll() is just a shortcut to call Run() with pre-populated filter argument.
Arkatufus
commented
Jan 11, 2022
| @@ -21,6 +21,7 @@ public class SerializeStructsBenchmark : HyperionBenchmark | |||
|
|
|||
| protected override void Init() | |||
| { | |||
| base.Init(); | |||
There was a problem hiding this comment.
The actual fix, base.Init() sets the Serializer field.
eaba
reviewed
Jan 11, 2022
| @@ -8,8 +8,16 @@ class Program | |||
| { | |||
| static void Main(string[] args) | |||
| { | |||
| var benchmark = BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()); | |||
| benchmark.RunAll(); | |||
| var benchmark = BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly); | |||
| } | ||
| else | ||
| { | ||
| benchmark.Run(args); |
There was a problem hiding this comment.
|
|
||
| if (args.Length == 0) | ||
| { | ||
| benchmark.RunAll(); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyperion.Benchmarks.SerializeStructsBenchmark did not initialize the
Serializerfield duringInit()properly, it is null and NRE crashes the benchmark.