Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SerializeStructBenchmark, Serializer not initialized #282

Merged
merged 1 commit into from
Jan 11, 2022
+11 −2
Merged

Fix SerializeStructBenchmark, Serializer not initialized #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Hyperion.Benchmarks/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,16 @@ class Program
{
static void Main(string[] args)
{
var benchmark = BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly());
benchmark.RunAll();
var benchmark = BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


if (args.Length == 0)
{
benchmark.RunAll();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/dotnet/BenchmarkDotNet/blob/63e28c100a42a6492d09a0b93a8a4c141061bb0d/src/BenchmarkDotNet/Running/BenchmarkSwitcher.cs#L53

}
else
{
benchmark.Run(args);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight changes so we can pass arguments to BenchmarkDotNet from command line.
RunAll() is just a shortcut to call Run() with pre-populated filter argument.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/dotnet/BenchmarkDotNet/blob/63e28c100a42a6492d09a0b93a8a4c141061bb0d/src/BenchmarkDotNet/Running/BenchmarkSwitcher.cs#L61

}
}
}
}
1 change: 1 addition & 0 deletions src/Hyperion.Benchmarks/SerializeStructsBenchmark.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public class SerializeStructsBenchmark : HyperionBenchmark

protected override void Init()
{
base.Init();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix, base.Init() sets the Serializer field.

standardValue = new StandardStruct(1, "John", "Doe", isLoggedIn: false);
blittableValue = new BlittableStruct(59, 92);
testEnum = TestEnum.HatesAll;
Expand Down