Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Akka.Cluster Startup #5398

Merged
merged 8 commits into from
Nov 25, 2021
Merged

Conversation

Zetanova
Copy link
Contributor

The cluster core loading task does not need to lock anymore.
To let the constructor finish will resolve racy Cluster.Get(system) issues

Should fix issue: #5397

@Zetanova
Copy link
Contributor Author

very strange, the tests does not fail on my machine.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes but otherwise I think this looks good. I'll add those myself on a separate PR.

src/core/Akka.Cluster/Cluster.cs Show resolved Hide resolved
src/core/Akka.Cluster/Cluster.cs Outdated Show resolved Hide resolved
src/core/Akka.Cluster/Cluster.cs Outdated Show resolved Hide resolved
@Aaronontheweb Aaronontheweb added this to the 1.4.29 milestone Nov 24, 2021
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) November 24, 2021 19:18
auto-merge was automatically disabled November 24, 2021 20:17

Head branch was pushed to by a user without write access

Copy link
Contributor Author

@Zetanova Zetanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) November 24, 2021 23:59
@Aaronontheweb Aaronontheweb merged commit bcd4bc3 into akkadotnet:dev Nov 25, 2021
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Dec 17, 2021
Aaronontheweb added a commit that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants