Resolve Akka.Cluster startup #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this on my machine using @Arkatufus' suggestion: #5435 (comment) @Arkatufus - are you able to reproduce the error from v1.4.29 on this PR? |
|
I'll give it a go |
|
Works just fine under a single core environment, all Akka.Cluster.Tools.Tests and Akka.Cluster.Tests specs passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think some of the race conditions that began to appear as a result of .NET 6's threadpool changes hid some of the faults exposed by this PR and some of the other Akka.Cluster ones. We need to carefully and quickly restore this functionality since #5435 is a critical issue.