Mark socket connection messages with IDeadLetterSuppression #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Dec 3, 2021
| @@ -53,7 +50,8 @@ public override TcpExt CreateExtension(ExtendedActorSystem system) | |||
|
|
|||
| #region internal connection messages | |||
|
|
|||
| internal abstract class SocketCompleted : INoSerializationVerificationNeeded { } | |||
| internal abstract class SocketCompleted : INoSerializationVerificationNeeded, IDeadLetterSuppression | |||
|
Clearing milestone since the issue this resolves is part of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5318
Socket connection messages like SocketReceived can arrive late to a dead socket listener after the socket actor is closed.
The log message from the deadletter actor made it look like it is a bigger problem than it is, when we know that this is a benign behaviour.
Marking these messages as IDeadLetterSuppression so it will not confuse user when it happens.