Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark socket connection messages with IDeadLetterSuppression #5412

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Mark socket connection messages with IDeadLetterSuppression #5412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/core/Akka/IO/Tcp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@
//-----------------------------------------------------------------------

using System;
using System.Reflection;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Runtime.CompilerServices;
using Akka.Actor;
using Akka.Configuration;
using Akka.Dispatch;
Expand Down Expand Up @@ -53,7 +50,8 @@ public override TcpExt CreateExtension(ExtendedActorSystem system)

#region internal connection messages

internal abstract class SocketCompleted : INoSerializationVerificationNeeded { }
internal abstract class SocketCompleted : INoSerializationVerificationNeeded, IDeadLetterSuppression
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{ }

internal sealed class SocketSent : SocketCompleted
{
Expand Down
4 changes: 2 additions & 2 deletions src/core/Akka/IO/Udp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
//-----------------------------------------------------------------------

using System;
using System.Reflection;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Runtime.CompilerServices;
using Akka.Actor;
using Akka.Configuration;
using Akka.Event;
using Akka.IO.Buffers;

namespace Akka.IO
Expand All @@ -34,7 +34,7 @@ public class Udp : ExtensionIdProvider<UdpExt>
{
#region internal connection messages

internal abstract class SocketCompleted : INoSerializationVerificationNeeded
internal abstract class SocketCompleted : INoSerializationVerificationNeeded, IDeadLetterSuppression
{
public ByteString Data { get; }

Expand Down
4 changes: 2 additions & 2 deletions src/core/Akka/IO/UdpConnected.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
//-----------------------------------------------------------------------

using System;
using System.Reflection;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Runtime.CompilerServices;
using Akka.Actor;
using Akka.Configuration;
using Akka.Event;
using Akka.IO.Buffers;

namespace Akka.IO
Expand Down Expand Up @@ -45,7 +45,7 @@ public class UdpConnected : ExtensionIdProvider<UdpConnectedExt>
// SocketAsyncEventArgs should never leave the ReceiveAsync() method and the OnComplete callback. It should
// be returned immediately to PreallocatedSocketEventAgrsPool so that the buffer can be safely pooled back.

internal abstract class SocketCompleted : INoSerializationVerificationNeeded
internal abstract class SocketCompleted : INoSerializationVerificationNeeded, IDeadLetterSuppression
{
public ByteString Data { get; }

Expand Down