fix(select): select not rendering option wrapped in ng container

[aefox]

Please read and mark the following check list before creating a pull request:

• I read and followed the CONTRIBUTING.md guide.
• I read and followed the New Feature Checklist guide.

Short description of what this resolves:

This fixes issue mentioned in #1063 related to nb-select not rendering nb-options that are wrapped in ng-container

[yggg]

As always, thanks for help @aefox! 👍

[yggg]

Not sure if it's ok to select ng-container here. This way it would be possible to pass arbitrary content into select. What do you think @aefox? Probably there is something we could do to restrict ng-container content (e.g. more specific selector)?

[aefox]

@yggg I totally see your point on possible to pass arbitrary content into select. That indeed is a problem I did not figure out, nice catch 👍

At the same time, please note the following hack/trick:

<nb-select placeholder="Select Showcase" [(selected)]="selectedItem">
  <ng-container *ngFor="let item of items" ngProjectAs="nb-option">
    <div>{{ item.label }}</div>
  </ng-container>
</nb-select>

This is currently possible to do and it works. Works here means it actually renders the divs correctly (they ofc do not work as an option, but that is expected).

I'm not sure if we should force the users of nebular to restrict them from using ng-container in this situation as probably some devs will prefer to use ng-container for loops and keep their nb-options cleaner.

Indeed doing this we're opening up the possibility for miss usage, but the same can happen for the pure html tags (select and option).

I'm basically opened to doing this any way you think it is best.

[nu5rim3]

any update?

[JihadMotii-REISys]

Any updates?