Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search for SurveyedLocales #3408

Closed
stellanl opened this issue Feb 6, 2020 · 2 comments
Closed

Fix search for SurveyedLocales #3408

stellanl opened this issue Feb 6, 2020 · 2 comments
Assignees
@stellanl
Labels
1 - Assignment Bug Mark which issues are related to bugs

Comments

@stellanl
Copy link
Contributor

stellanl commented Feb 6, 2020 •
edited
Loading

In the /rest/surveyed_locales endpoint, if a cursor string (since= parameter) is used with the search parameter, it is applied to both lookups; display name and identifier. It comes from the previous name-prefix lookup, and should not be used for the identifier lookup (which should yield at most one result).
@stellanl stellanl self-assigned this Feb 6, 2020
stellanl added a commit that referenced this issue Feb 6, 2020
@stellanl
[#3408]Do not use since in identifier search.
2b655ea
valllllll2000 pushed a commit that referenced this issue Feb 6, 2020
Merge pull request #3409 from akvo/issue/3408-only-one-since-in-search
6a9dbde 
[#3408]Do not use "since" parameter in identifier search.
@muloem
Copy link
Member

muloem commented Feb 7, 2020

@stellanl in addition to this, it also appears that datapoints are returned even if they are not part of the survey to which the assignment belongs

@iperdomo iperdomo added the Bug Mark which issues are related to bugs label Feb 17, 2020
@iperdomo
Copy link
Contributor

@stellanl @muloem I think this is a showstopper We need to fix it for releasing 1.11

stellanl added a commit that referenced this issue Feb 17, 2020
@stellanl
[#3408]Use surveyGroupId when searching.
1947d65
iperdomo added a commit that referenced this issue Feb 17, 2020
@iperdomo
Merge pull request #3420 from akvo/issue/3408-only-one-since-in-search
11c7627 
[#3408]Use surveyGroupId when searching.
stellanl added a commit that referenced this issue Feb 17, 2020
@stellanl
[#3408]Add db indices.
c12e7c5
iperdomo added a commit that referenced this issue Feb 17, 2020
@iperdomo
Merge pull request #3421 from akvo/issue/3408-only-one-since-in-search
65a8712 
[#3408]Add db indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stellanl stellanl

Labels
1 - Assignment Bug Mark which issues are related to bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iperdomo @stellanl @muloem